Claude/code review recommendations 017 wk6mi2g eoh5 bb rh gvor ts - #5
Merged
leifuss merged 23 commits intoDec 6, 2025
Merged
Conversation
- Fix CSS height conflict (maps were 135% total, now 100%) - Add loading overlay with spinner and status updates - Add proper CSV parser that handles quoted fields correctly - Add data caching to avoid repeated CSV loading - Add error handling with user-friendly retry option - Add in-app legend panel explaining color coding - Refactor littoral symbology to cleaner loop-based code - Improve README with comprehensive documentation
- Add slide-out menu for Place Directory on mobile - Add hamburger menu toggle button (visible <768px) - Add dark overlay when menu is open - Maps go full-width on mobile - Larger touch targets for tree items - Menu auto-closes when selecting a place - Responsive title sizing for small screens
- Fix string/number concatenation bug in schnetz_page calculation - Properly parse schnetz_page as integer before adding offset - Handle missing/empty values gracefully with fallbacks - Titles now display correctly for all records including Casinum
- Remove UTF-8 BOM from ravenclaw.csv and rc_littoral.csv - BOM was causing field name mismatch (first field was '\ufeffrc_index_no') - Simplify title functions now that field names match correctly - Remove debug logging
- Using function for title prevents ArcGIS from loading all fields - Reverted to pure template substitution which works correctly - Moved Schnetz PDF link to popup content instead of title
- Add Cinzel & Crimson Text fonts for classical look - New header with gradient background and gold accents - Styled popups with serif fonts and warm colors - Updated sidebar with parchment-style background - Themed loading spinner and legend panel - Mobile menu button matches new color scheme
- Added closePlaceDetails() and showPlaceDetails() functions - Place Details Panel shows in sidebar when a place is selected - Displays same info as map popups but doesn't obscure maps - Added Quick Links (About/Feedback) to sidebar for mobile accessibility - Wired up both RC Cities and Littoral place selections to sidebar panel
- Re-open sidebar on mobile when place details are shown - This ensures the panel is visible instead of hidden off-screen - Added small delay before scrolling to let sidebar animate open
- Moved showPlaceDetails/closePlaceDetails functions to head section (ensures they're defined before being called from other functions) - Added null check for panel elements with console logging - Removed About/Feedback from header (kept only in sidebar menu) - Simplified header structure
- Added console.log statements to trace showPlaceDetails execution - Log panel element references and display style changes - This will help diagnose why the panel isn't appearing
- Added Calcite CSS and JavaScript module imports - Prepares for migration from deprecated Expand widgets - Widgets still use legacy patterns but Calcite is now available
- Replaced deprecated Fullscreen widget with <arcgis-fullscreen> web component - Added extensive debugging to locate_toponym_on_geoMap to trace execution - Added try-catch around showPlaceDetails call to catch errors - Removed Fullscreen imports from require() statements
….0.2.1) - Added popup visibility watchers for both map views to show sidebar panel when clicking directly on map features (not just from directory) - Converted all Expand widgets to <arcgis-expand> web components - Removed deprecated Expand imports from require() statements - Changed symbology picker icon from buffer-point to legend - This should fix the blank icon squares issue
- Reverted Expand/Fullscreen from web components back to legacy widgets (web components weren't rendering icons when created programmatically) - Fixed popup watcher: now watches selectedFeature directly instead of visible property, which should trigger sidebar panel on map clicks - Legacy widgets show deprecation warnings but work correctly
The Schnetz edition page numbers don't match the PDF page numbers due to front matter. This fix adds +14 offset to the URL while still displaying the original edition page number to users. Updated: - rc_popup template (converted to content function for calculation) - littoral_popup template (converted to content function for calculation) - showPlaceDetails function for both littoral and RC cities
…0.2.4) Remove content from popup templates since the sidebar Place Details Panel now handles all the detailed information. This makes popups smaller and cleaner while the panel provides the full details including the Schnetz link with correct +14 page offset.
…v.0.2.5) On first map click, the popup's selectedFeature may not have all attributes loaded yet. Now the popup watchers query the layer directly to get complete feature attributes before populating the sidebar panel.
Added: - Version history section documenting v.0.2.5 changes - Place Details Panel feature description - Schnetz PDF offset fix note - Mobile improvements documentation - Note about mobile-responsive design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.