Skip to content

Bump stylelint-scss from 5.3.2 to 7.0.0 #14492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

Bump stylelint-scss from 5.3.2 to 7.0.0 #14492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kolibri-format/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"stylelint-config-sass-guidelines": "11.1.0",
"stylelint-config-standard": "34.0.0",
"stylelint-csstree-validator": "3.0.0",
"stylelint-scss": "5.3.2"
"stylelint-scss": "7.0.0"

@rtibblesbot rtibblesbot Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: stylelint-scss@7.0.0 declares peerDependencies: { stylelint: "^16.8.2 || ^17.0.0" }, but this package has stylelint: "^15.11.0". The lockfile resolves it against stylelint 15.11.0 — an unsupported combination.

CI lint passes today, but upstream bug fixes and new rules may only be tested against stylelint 16/17. This could lead to silent breakage that's difficult to diagnose.

Guidance: Upgrade stylelint to ^16.8.2 (or ^17.0.0) in this same PR, along with any config packages that may need corresponding updates (stylelint-config-standard, stylelint-config-recommended-scss, etc.). Alternatively, if a stylelint upgrade is too large to bundle here, consider staying on stylelint-scss@6.x which supports stylelint ^16.8.2 — though that would also require upgrading stylelint from 15.

@rtibblesbot rtibblesbot Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: (re-raised from prior review — unaddressed)

stylelint-scss@7.0.0 declares peerDependencies: { stylelint: "^16.8.2 || ^17.0.0" }, but this package has stylelint: "^15.11.0". CI passes today because pnpm installed it anyway, but this is an unsupported combination — upstream only tests against stylelint 16/17, so future rule behavior may silently diverge.

Guidance: Either upgrade stylelint to ^16.8.2 in this PR (along with any config changes the major bump requires), or close this PR and open a combined stylelint + stylelint-scss upgrade.

},
"engines": {
"node": ">= 20.19.0",
Expand Down
51 changes: 25 additions & 26 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading