Skip to content

fix(store): fix internal revert incompatibilities - #3612

Open
dk1a wants to merge 2 commits into
latticexyz:mainfrom
dk1a:dk1a/fix-multiple-internal-expectRevert
Open

fix(store): fix internal revert incompatibilities#3612
dk1a wants to merge 2 commits into
latticexyz:mainfrom
dk1a:dk1a/fix-multiple-internal-expectRevert

Conversation

@dk1a

@dk1a dk1a commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

An internal revert halts everything after it in the test
So the second internal revert will never be reached
Any other code after an internal revert will also never be reached

So I make some store calls public (most already are, those tests were unnecessary exceptions)

And remove some unreachable unimportant code in a couple other places

@changeset-bot

changeset-bot Bot commented Feb 28, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5255e1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dk1a
dk1a marked this pull request as ready for review February 28, 2025 17:40
@dk1a
dk1a requested a review from alvrs as a code owner February 28, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant