You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Calling _spliceDynamicData with an overflowing deleteCount, it triggers a default arithmetic error
If it instead triggered Store_InvalidSplice, it would've saved me a couple hours of debugging
I also add tests, for this new behaviour and for the previous way Store_InvalidSplice was used
My used of unchecked isn't important and I can remove it if you don't like it
I assume this is also blocked by audit, so I'm stockpiling PRs for whenever that happens
note to self about updating store logs: pnpm with-anvil vitest --update --hookTimeout=1000000
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The arithemetic error I replace with a custom error comes from the definition of previousFieldLength, which is unchanged in #3521
The error alvarius changes is unrelated and happens later
(edited after realizing it's even less related than I initially thought, in case you read the previous version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
_spliceDynamicDatawith an overflowingdeleteCount, it triggers a default arithmetic errorIf it instead triggered
Store_InvalidSplice, it would've saved me a couple hours of debuggingI also add tests, for this new behaviour and for the previous way
Store_InvalidSplicewas usedMy used of
uncheckedisn't important and I can remove it if you don't like itI assume this is also blocked by audit, so I'm stockpiling PRs for whenever that happens
note to self about updating store logs:
pnpm with-anvil vitest --update --hookTimeout=1000000