-
Notifications
You must be signed in to change notification settings - Fork 0
Icca data source #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Dr-awe
wants to merge
58
commits into
main
Choose a base branch
from
Icca-data-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Icca data source #56
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
855ad6d
add color icon to dependency wheel so that during instal with Pypi it…
alexisj-inria 7ed71dc
Add opportunity to save outputs outside of the input folder (read-onl…
alexisj-inria ce68d69
Improve discovery message in case of empty folder
alexisj-inria 083b963
Improved *datetime* column auto-detection based on name and content
alexisj-inria 08638e7
sort plot type to have time series first
alexisj-inria 316817f
reload patient option now uses default for entry not filed in patient…
alexisj-inria f7adeca
Benchmark for time and memory consumption
alexisj-inria 3b96c6b
First implementation, not perfect, some huge wins, some significant r…
alexisj-inria 672482a
Avoid loading twice df if there is no timewindow anyway
alexisj-inria 8269dc1
Improved parquet reading efficiency for datetime column detection
alexisj-inria 6ebf3d3
ruff check
alexisj-inria bbef388
Solve issue about index modifying original
alexisj-inria 1883a2c
Remove useless deep coppies and unify dedup-then-sort process everywh…
alexisj-inria bf3e5c3
improve benchmark to account for partial column loading
alexisj-inria fefa2ad
claude.md update for issue tracking
alexisj-inria 4c6dd0d
column selection and pruning before loading to reduce load duration
alexisj-inria 837e2fa
Improving naming and code quality
alexisj-inria d730d78
Merge pull request #63 from larib-data/improve-loading-time-and-memory
AlexisJanin 83c83a8
user-options feature
alexisj-inria 9d5d18c
dash_api folder comments cleaned
alexisj-inria 4b239d4
Improve docstring and namings from dash_api folder
alexisj-inria 4cfbd7e
Improved naming, inline comment and docstring for the entirety of /sr…
alexisj-inria eb6b720
Improved variable naming across whole code
alexisj-inria 7fac3a8
Improved library wise naming and adr about user-options override or f…
alexisj-inria 2d9938f
Improving user-options backend and UI. Adding many user-options
alexisj-inria 7a6f9c1
Store datetime_start/datetime_end as tz-aware instants (issue #68)
alexisj-inria 09b6fbf
Finish issue 68 with review
alexisj-inria ef9e2ba
Issue 69 done: display timezone now is a user-option
alexisj-inria f0163a4
Improving code style and quality
alexisj-inria cd8757c
bump version as this might get distributed as beta
alexisj-inria d26815f
Merge pull request #70 from larib-data/issue-68-and-follow-ups
AlexisJanin f9d4dc5
Add extended diagnostic for not output from CLI scripts
alexisj-inria c46aa66
Issue 66 solved: inspect can prune columns at read
alexisj-inria a9d9d10
Improving contribution rules about clinicalScope processing being lig…
alexisj-inria 68edcf5
Spectrogram feature first implementation
alexisj-inria 45bf512
.edf datasource added
alexisj-inria 74648bb
Fixing bad eeg data i nthe example, keep good signals
alexisj-inria fab5b1c
psd plot type added (issue 73)
alexisj-inria 7601cca
Extending other data source support by using database option specific…
alexisj-inria c7dfc58
Per-file trace style, source symlinks and stem dedup for the other da…
alexisj-inria 60a4adb
Remove philips_waves, philips_numerics and syringe datasources (issue…
alexisj-inria f7ee7ed
Update docs, skills and the pushdown benchmark for the datasource rem…
alexisj-inria 4a234fa
Add TraceOption exposure onto xslx file
alexisj-inria 010246e
Address code-review follow-ups on spectrogram/PSD/other-source PR
alexisj-inria 52b5006
Split example/ by audience and make the demo config canonical
alexisj-inria 49d74ca
Align every demo datasource to a common start time
alexisj-inria ba7626d
Review for sdandar and maintainability
alexisj-inria a206314
fixed bug abotu spectral computation
alexisj-inria 88db72d
Merge pull request #76 from larib-data/new-plot-type-spectrogram
AlexisJanin ae5aa7c
Make CI green: reformat under ruff 0.16, drop stale suppressions
alexisj-inria b1ca1b2
Release 1.1.0: document the full changelog and bump version
alexisj-inria e02a820
Fix two user-options defects found in pre-merge review
alexisj-inria f5ca22a
Back-fill three ADRs and correct a stale PSD example
alexisj-inria 40d103c
Prune comments that narrate instead of explain
alexisj-inria e3d0dc8
Tighten the docs this release grew
alexisj-inria a5620c1
Ruff format
alexisj-inria 1f0d353
new files for icca
Dr-awe e9666b0
Big session !
Dr-awe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Unreleased]still reads_Nothing yet._— a new datasource is user-visible surface and needs an entry. The precedent is EDF's bullet under 1.1.0 Added (line 28):Suggested: