Skip to content

fix(lifecycle): run patch image commands on standalone control-plane hosts #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuisongliu merged 1 commit into from
Oct 29, 2026
+7 −3
Merged

fix(lifecycle): run patch image commands on standalone control-plane hosts #7417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lifecycle/pkg/guest/guest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,13 @@ func (d *Default) Apply(cluster *v2.Cluster, mounts []v2.MountImage, targetHosts
eg, ctx := errgroup.WithContext(context.Background())
for j := range targetHosts {
node := targetHosts[j]
// Standalone control-plane binaries and services are managed by
// the dedicated lifecycle. Image hooks can replace that service.
if cluster.IsStandaloneControlPlane() && isControlPlaneHost(cluster, node) {
// Standalone control-plane binaries and services are managed
// by the dedicated lifecycle, so the rootfs image hooks never
// run on those hosts. Patch images are the supported way to
// layer host-level changes and still execute everywhere; the
// patch scripts themselves decide what to do per host.
if m.IsRootFs() && cluster.IsStandaloneControlPlane() &&
isControlPlaneHost(cluster, node) {
continue
}
envs := maps.Merge(m.Env, envGetter.Getenv(node))
Expand Down
Loading