refactor(BA-7765): switch resource_policy update DTO to Unset - #14429
Merged
Conversation
github-actions
Bot
added
size:L
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017idp6rKVV33XrzJG1yWYXo
wngh4628
force-pushed
the
feature/BA-7765-resource-policy-unset
branch
from
September 8, 2026 07:28
a977f97 to
3197ee5
Compare
Co-authored-by: octodog <mu001@lablup.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012izHF4dxgHeuYYhs3BCea6
Co-authored-by: octodog <mu001@lablup.com>
wngh4628
marked this pull request as draft
September 9, 2026 02:04
wngh4628
marked this pull request as ready for review
September 9, 2026 05:33
fregataa
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the
resource_policyupdate DTOs from the legacySentinelmarker toUnset(omitted = no change,null= clear).common/dto/manager/v2/resource_policy/request.py:UpdateKeypairResourcePolicyInput.total_resource_slots,max_pending_session_count,max_priority,max_pending_session_resource_slots,allowed_vfolder_hosts;UpdateUserResourcePolicyInput.max_vfolder_count,max_concurrent_logins,max_quota_scope_size; andUpdateProjectResourcePolicyInput.max_vfolder_count,max_quota_scope_sizechange fromX | Sentinel | None = SENTINELtoX | None | Unset = UNSET. Nullable fields describe "Omit to leave unchanged; null clears.", non-nullable ones stop at "Omit to leave unchanged."manager/api/adapters/resource_policy/adapter.py: the tenSentinelbranches are replaced withTriState.from_unset(...)(nullable columns) orOptionalState.from_unset(...)(non-nullable columns), using.map(...)where a value is converted.tests/unit/common/dto/manager/v2/resource_policy/test_request.py,tests/unit/manager/api/gql/resource_policy_v2/test_max_priority.py:SENTINEL/Sentinelassertions becomeUNSET/Unset.🤖 Generated with Claude Code
https://claude.ai/code/session_017idp6rKVV33XrzJG1yWYXo
📚 Documentation preview 📚: https://sorna--14429.org.readthedocs.build/en/14429/
📚 Documentation preview 📚: https://sorna-ko--14429.org.readthedocs.build/ko/14429/