refactor(BA-7761): switch runtime_variant_preset update DTO to Unset - #14419
Open
wngh4628 wants to merge 2 commits into
Open
refactor(BA-7761): switch runtime_variant_preset update DTO to Unset#14419wngh4628 wants to merge 2 commits into
wngh4628 wants to merge 2 commits into
Conversation
github-actions
Bot
added
comp:manager
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017idp6rKVV33XrzJG1yWYXo
wngh4628
force-pushed
the
feature/BA-7761-runtime-variant-preset-unset
branch
from
September 8, 2026 07:26
b903f0e to
9918d43
Compare
Co-authored-by: octodog <mu001@lablup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the
runtime_variant_presetupdate DTO from the legacySentinelmarker toUnset(omitted = no change,null= clear).common/dto/manager/v2/runtime_variant_preset/request.py:UpdateRuntimeVariantPresetInput.description,default_value,category,display_name, andui_optionchange fromX | Sentinel | None = SENTINELtoX | None | Unset = UNSET; each field description now reads "Omit to leave unchanged; null clears."; thedefault_valuevalidator skipsUnsetinstead ofSENTINEL.manager/api/adapters/runtime_variant_preset/adapter.py: the fiveSENTINELbranches are replaced withTriState.from_unset(...).🤖 Generated with Claude Code
https://claude.ai/code/session_017idp6rKVV33XrzJG1yWYXo
📚 Documentation preview 📚: https://sorna--14419.org.readthedocs.build/en/14419/
📚 Documentation preview 📚: https://sorna-ko--14419.org.readthedocs.build/ko/14419/