Repository navigation
feat(pool): report step-by-step worktree setup progress - #192
Open
bearomorphism wants to merge 7 commits into
Open
bearomorphism wants to merge 7 commits into
bearomorphism wants to merge 7 commits into
Conversation
…pers verbatim into cmd/e2e_test.go and deleted cmd/progress_e2e_test.go. Coverage and behavior are unchanged. All four tests and their subtests passed with go test ./cmd -run '^TestGetSetupProgress' -count=1 -v. git diff --check passed
…ar, preserving tree-prefixed step messages, plain redirected stderr, and path/JSON stdout. Animation clears around hook output and stops on success or failure; hook failures remain nonfatal. PTY regression tests failed before wiring the fix and passed afterward. Verified setup E2E tests across three runs, progress race tests across 20 runs, pool and hook tests, targeted go vet, Windows cross-build, and git diff --check. PTY tests are Unix-only; Windows runtime animation was not exercised
…umns or fewer), and unknown-width terminals now receive static progress. Animation rechecks width and bounds clearing after resizes. Hook streams track partial lines independently, preventing redirected stdout from enabling redraw over unfinished stderr. Regressions failed before the fix and passed afterward. Verified setup E2E tests across 3 runs, progress race tests across 20 runs, pool and hook tests, targeted go vet, Windows cross-build, and git diff --check. Windows runtime behavior was not exercised. No pipeline or PR actions performed
…ir original streams directly after the permanent tree-prefixed announcement, with no animation during hooks. Removed the writer wrapper and partial-line state. Git fetch/create/reuse animation, terminal-size and TERM=dumb safeguards, error cleanup, nonfatal warnings, and machine stdout remain intact. Updated README and existing cmd/e2e_test.go. Both new PTY regressions failed before the fix and passed afterward. Animation coverage now blocks a real Git checkout operation. Tests verify terminal identity, unbuffered-by-default newline streaming, acquisition completion while a background descendant remains alive, and no redraws after the hook announcement. Passed checks: - go test ./cmd -run '^(TestGetSetupProgress|TestGetHookPreservesTerminalAndLineBuffering|TestGetHookBackgroundChildDoesNotDelayLease)' -count=3 -v - go test ./cmd -run '^(TestGetHookPreservesTerminalAndLineBuffering|TestGetHookBackgroundChildDoesNotDelayLease)$' -count=20 - go test -race ./internal/pool -run '^TestSetupProgress' -count=20 - go test -race ./internal/hooks - make build - make test (all packages passed) - make lint (no formatting output or vet errors) - go vet ./cmd ./internal/pool ./internal/hooks - GOOS=windows go build ./... - GOOS=windows go test -c -o .ci-cmd.test.exe ./cmd (temporary binary removed) - git diff --check Baseline go test ./internal/pool ./internal/hooks also passed before the production fix. Limitations: PTY runtime verification was on macOS; Windows runtime and jj integration were not exercised. No external approvals, workflow reruns, pushes, or PR edits were performed. Read-only inspection confirmed PR kunchenguid#192 remains draft with a stale description. The outer executor must update it concisely to describe animation during Git setup only, paused for hooks to preserve terminal output, retaining Closes kunchenguid#54 and the generated attestation. Findings ci-1 through ci-4 were untouched
…nges. Reused existing E2E scenarios for progress ordering, skipped steps, hook routing, reuse, and machine-readable stdout. Replaced duplicated PTY runners with one socket-controlled harness covering animation during blocked Git, terminal capabilities, hook terminal identity/newline streaming, background-child completion, and no animation during hooks. Moved renderer tests unchanged into internal/pool/pool_test.go and deleted the standalone file. Production code and README are unchanged. Diff versus base: before +893/-5; after +574/-11. cmd/e2e_test.go decreased from +628/-0 to +317/-6. This round removes 325 net lines. Passed checks: - go test ./cmd -run '^TestGet(AndStatus|LeasePrintsOnlyPathToStdout|NoFetchUsesLocalRefs|LeaseAndStatusJSONContracts|ReusesWorktree|SetupProgress.*)$' -count=3 -timeout=5m -v - go test ./cmd -run '^TestGetSetupProgressTerminal$' -count=10 -timeout=5m - go test -race ./internal/pool -run '^TestSetupProgress' -count=20 -timeout=5m - go test ./internal/pool ./internal/hooks -timeout=10m - go test -race ./internal/hooks -timeout=5m - make build - make test - make lint - GOOS=windows go build ./... - GOOS=windows go test -c -o .ci-cmd.test.exe ./cmd - GOOS=windows go test -c -o .ci-pool.test.exe ./internal/pool - git diff --check Three temporary build-overlay mutations failed at the intended behavioral assertions: disabling animation, restoring hook-writer pipes, and restoring pipes only for the background hook. Temporary verification files and cross-compiled test binaries were removed. PTY runtime verification was on macOS; Windows runtime was not exercised. No pushes, PR/draft/description/attestation edits, media uploads, or external workflow approval/rerun actions were performed. Findings ci-1 through ci-4 remain untouched
bearomorphism
marked this pull request as ready for review
October 19, 2026 07:40
 [Medium impact] The PR appears safe to merge; the previous fetch-prompt issue is fixed. Reviews (2) · Last reviewed commit: "no-mistakes(ci): Fixed greptile-fetch-pr..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…le diff: 33 insertions, 13 deletions. internal/pool/pool.go now prints the existing fetch step directly to stderr and calls vcs.Fetch without animation, because Git/SSH can prompt through the controlling terminal even with redirected stdin. Create/reuse animation and product semantics are otherwise unchanged. README explains the distinction. Extended the existing cmd/e2e_test.go PTY harness with a real controlling terminal and local upload-pack helper that prompts through /dev/tty, validates a dummy response, and executes Git. Assertions reject redraw/erase bytes throughout fetch and retain valid lease JSON, blocked-checkout animation, terminal-mode, and hook regressions. The background fixture now synchronizes readiness before terminal teardown and ignores hangup. The final regression failed against original production code using a temporary build overlay and passed with the fix. Temporary verification files were removed. Passed checks: - go test ./cmd -run '^TestGet(AndStatus|LeasePrintsOnlyPathToStdout|NoFetchUsesLocalRefs|LeaseAndStatusJSONContracts|ReusesWorktree|SetupProgress.*)$' -count=3 -timeout=5m -v - go test ./cmd -run '^TestGetSetupProgressTerminal$' -count=10 -timeout=5m - go test -race ./internal/pool -run '^TestSetupProgress' -count=20 -timeout=5m - go test -race ./internal/hooks -timeout=5m - make build - make test - make lint - GOOS=windows go build ./... - GOOS=windows go test -c -o .ci-cmd.test.exe ./cmd - GOOS=windows go test -c -o .ci-pool.test.exe ./internal/pool - git diff --check Initial fixture failures were corrected before final successful validation. PTY runtime verification was on macOS; Windows runtime was not exercised. No pipeline-control commands, pushes, PR state/body changes, replies, uploads, approvals, or workflow reruns were performed. Findings ci-1 through ci-4 remain untouched
Owner
|
Speaking as Kun's firstmate: thanks @bearomorphism. I approved the fork CI runs for I'll do the full contract and VISION review once CI finishes. A heads-up so it doesn't surprise you: the plain stderr step lines match what #54 asked for, but the animated bar on interactive terminals is new on-by-default output, so this may need Kun's call rather than an auto-merge. If so, I'll say that plainly here so you know it isn't waiting on you. |
Owner
|
Speaking as Kun's firstmate: CI is fully green on This is now a captain-decision hold. It is not waiting on you. Every unconfigured Contract-class: new-default (new default-on progress output, including a terminal animation, on every VISION per-rule (
|
Author
|
This is a feature change. You probably need a human to review the result and sign off the PR? Thanks. |
Owner
|
Speaking as Kun's firstmate: yes, exactly right, @bearomorphism. Because this adds new on-by-default output to every Nothing is waiting on you. If Kun asks for changes, I'll post them here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Closes #54
Demo
Real CLI capture; checkout was held briefly to make the animation visible.
Testing
Pipeline
Updates from git push no-mistakes