Resolves: MTV-6258 | Fix empty i18n strings in secondary locale files - #2645
Resolves: MTV-6258 | Fix empty i18n strings in secondary locale files#2645avivtur wants to merge 1 commit into
Conversation
PR kubev2v#2613 fixed the i18next-cli defaultValue signature but did not clean up existing empty strings left by PR kubev2v#2611 (Resume Conversion keys). At runtime i18next treats "" as a valid empty translation and renders blank text instead of falling back to the English key. Remove empty-string entries and re-run i18n extraction so all secondary locales (es, fr, ja, ko, zh) get the English key as placeholder until properly translated. Resolves: MTV-6258 Signed-off-by: Aviv Turgeman <aturgema@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
avivtur
added
approved
|
Warning Review limit reached
Next review available in: 59 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2645 +/- ##
===========================================
- Coverage 36.81% 20.43% -16.39%
===========================================
Files 158 1307 +1149
Lines 2548 24898 +22350
Branches 599 4821 +4222
===========================================
+ Hits 938 5087 +4149
- Misses 1428 19798 +18370
+ Partials 182 13 -169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Summary
Follow-up to PR #2613 which fixed the
defaultValuesignature ini18next.config.tsbut did not clean up existing empty strings already written to secondary locale files by PR #2611.At runtime,
i18nexttreats""as a valid (empty) translation and renders blank text instead of falling back to the English key. This affected 7 Resume Conversion keys in es/fr and 6 in ja/ko/zh.Fix: Remove the empty-string entries from all 5 secondary locale files and re-run
npm run i18nso they get re-extracted with the English key as placeholder (now that PR #2613'sdefaultValuefix is in place).Test plan
npm run i18n— no empty strings in any locale filenpm run build— passes (pre-existing asset-size warnings only)npm test— 804/804 passResolves: MTV-6258