[scanner] fix: remove --pool=threads override in Coverage Suite workflow#20440
Conversation
✅ Deploy Preview for kubestellarconsole canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
There was a problem hiding this comment.
Pull request overview
Removes a hardcoded Vitest CLI override in the Coverage Suite workflow so the workflow respects the repo’s Vitest configuration defaults (avoiding threads pool mode that can cause cross-test-file mock contamination in CI coverage runs).
Changes:
- Removed
--pool=threadsfrom the Coverage Suite Vitest invocation in.github/workflows/coverage-hourly.yml.
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
Fixes #20439
Root Cause
PR #20435 reverted
pool: 'threads'inweb/vite.config.ts(line 324) and removedvi.restoreAllMocks()fromweb/src/test/setup.ts, but the Coverage Suite workflow still had--pool=threadshardcoded on line 69 of.github/workflows/coverage-hourly.yml.This CLI flag overrides the vite.config.ts setting, forcing threads pool mode despite the revert. Threads share memory across test files → mock cross-contamination → 265 test failures.
Fix
Removed
--pool=threads \from workflow line 69. Tests now use default pool mode (forks) withisolate: true, providing proper test isolation and preventing mock leaks between files.Verification
Next Coverage Suite run will use forks pool (one process per test file). Expected outcome: 265 failures resolve.