Skip to content

[scanner] fix: remove --pool=threads override in Coverage Suite workflow#20440

Merged
clubanderson merged 2 commits into
mainfrom
scanner/fix-20439
Jul 7, 2026
Merged

[scanner] fix: remove --pool=threads override in Coverage Suite workflow#20440
clubanderson merged 2 commits into
mainfrom
scanner/fix-20439

Conversation

@clubanderson

Copy link
Copy Markdown
Collaborator

Fixes #20439

Root Cause

PR #20435 reverted pool: 'threads' in web/vite.config.ts (line 324) and removed vi.restoreAllMocks() from web/src/test/setup.ts, but the Coverage Suite workflow still had --pool=threads hardcoded on line 69 of .github/workflows/coverage-hourly.yml.

This CLI flag overrides the vite.config.ts setting, forcing threads pool mode despite the revert. Threads share memory across test files → mock cross-contamination → 265 test failures.

Fix

Removed --pool=threads \ from workflow line 69. Tests now use default pool mode (forks) with isolate: true, providing proper test isolation and preventing mock leaks between files.

Verification

Next Coverage Suite run will use forks pool (one process per test file). Expected outcome: 265 failures resolve.

PR #20435 reverted pool:'threads' in vite.config.ts but workflow still
hardcoded --pool=threads on line 69, forcing threads mode despite config.
Threads share memory → mock cross-contamination → 265 test failures.

Fixes #20439

Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
Copilot AI review requested due to automatic review settings July 7, 2026 03:54
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 7, 2026
@netlify

netlify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 957ba6d
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a4c84bf9af0860008f6b083

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a hardcoded Vitest CLI override in the Coverage Suite workflow so the workflow respects the repo’s Vitest configuration defaults (avoiding threads pool mode that can cause cross-test-file mock contamination in CI coverage runs).

Changes:

  • Removed --pool=threads from the Coverage Suite Vitest invocation in .github/workflows/coverage-hourly.yml.

@clubanderson clubanderson merged commit ff333a7 into main Jul 7, 2026
15 of 16 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-20439 branch July 7, 2026 04:47
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit ff333a7cf669992cc01a0e88945c82a47de89c92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/3-restricted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 265 test failure(s) in Coverage Suite run #4115

2 participants