Skip to content

🐛 fix: revert vi.restoreAllMocks() breaking 265 tests #20435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Jul 7, 2026
Merged

🐛 fix: revert vi.restoreAllMocks() breaking 265 tests #20435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion web/src/test/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ afterEach(() => {
window.sessionStorage?.clear()
}
vi.unstubAllEnvs()
vi.restoreAllMocks() // Restore mocks but preserve global stubs (e.g., localStorage) (#20007)
vi.clearAllMocks()
})

Expand Down
2 changes: 1 addition & 1 deletion web/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ export default defineConfig(({ mode }) => ({
isolate: true,
// CI: use threads pool instead of forks to prevent OOM from subprocess spawn storm (#20007)
// Threads share memory, no fork overhead. Local dev uses default (forks) for stronger isolation.
pool: process.env.CI ? 'threads' : undefined,
// pool: process.env.CI ? 'threads' : undefined, // Reverted: threads share memory, can cause mock cross-contamination
Comment on lines 322 to +324
coverage: {
provider: 'v8',
// Disable coverage.all to prevent force-importing source files that trigger
Expand Down
Loading