feat: ship the Testkube sign-in pages in the image - #1
Open
dejanzele wants to merge 1 commit into
Open
Conversation
Dex renders its own sign-in, error, and device pages. This commit makes the Testkube look part of the kubeshop/dex image: testkube/web/ holds nine templates that replace the upstream templates and the static assets (CSS, wordmark, favicon, Roboto fonts, background images) served at /static/testkube/. The Dockerfile copies them into /srv/dex/web and sets DEX_FRONTEND_DIR, so a deployment needs no frontend configuration. The values in styles.css copy the Testkube dashboard build 1:1; the header comment lists the sources. The only per-environment value is frontend.extra.dashboardURL, used by the error page's "Back to Testkube" button. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UrZjx4CiwP6eWyC6FM2tn1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dex renders its own sign-in, error, and device pages. Until now the
kubeshop/deximage showed the default Dex theme, so a failed Testkube login showed a "dex" logo. This PR makes the Testkube look part of the image, the same way this fork already builds upstream Dex: upstreamv2.45.1plus one commit.testkube/web/templates/: nine templates that replace the upstream templates.testkube/web/static/testkube/: CSS, wordmark, favicon, Roboto fonts, background images, served at/static/testkube/.Dockerfile: three lines after the upstreamweb/copy, plusENV DEX_FRONTEND_DIR=/srv/dex/web, so a deployment needs nofrontendconfiguration.The values in
styles.csscopy the Testkube dashboard build 1:1 (Colors.ts, theAuthPage*/Banner/AuthForm*styled-components, the antd theme tokens,MediaQueries.tsintestkube-cloud-api/js/packages/web). The header comment instyles.csslists the sources. Seetestkube/README.md.The base branch
release/v2.45.1is upstreamv2.45.1, so the diff is this commit only.Pages
Input.Passwordshow/hide toggleVerification
docker runof an overlay build with a nine-line Dex config and nofrontendblock renders the branded pages; all static assets return 200.r.NotFoundHandler = http.NotFoundHandler()inserver.go); a later commit can rendererror.htmlthere..Connectors,.PostURL,.Invalid,.Username,.UsernamePrompt,.BackLink,.ErrType,.ErrMsg,.Scopes,.Client,.AuthReqID,.UserCode,.ClientName,.Code) and theurl/extra/lowerfuncs.Release
Tag the merge result
v2.45.2(fork convention, likev2.42.2) and dispatch the image workflow on it to publishkubeshop/dex:2.45.2. The enterprise chart pins that tag in kubeshop/testkube-cloud-api#5360.The only per-environment value is
frontend.extra.dashboardURL; the error page uses it for the "Back to Testkube" button. Without it the button returns to the previous page.🤖 Generated with Claude Code
https://claude.ai/code/session_01UrZjx4CiwP6eWyC6FM2tn1