Repository navigation
馃尡 Upgrade golangci-lint to v2.14.0 and enable promlinter, reassign linters - #1488
Merged
kubernetes-prow[bot] merged 1 commit intoOct 14, 2026
Merged
Conversation
- Update golangci-lint version from v2.13.1 to v2.14.0 in GitHub workflow - Enable promlinter linter for Prometheus metrics naming checks - Enable reassign linter for package variable reassignment checks - Fix go vet warnings by renaming WriteTo to Write in Span interface to avoid conflict with io.WriterTo standard library interface Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
kubernetes-prow
Bot
added
cncf-cla: yes
Member
|
Thx! /lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 582e5f9beeb023d2fa141187e47f30767f584af5 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dongjiang1989, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
ref: kubernetes-sigs/controller-runtime#3619
promlinter(Prometheus metrics naming) andreassign(package variable reassignment checks)go vetwarnings by renamingWriteTotoWritein theSpaninterface to avoid conflict withio.WriterTostandard library interfaceWhy do we need it?
Keeping the linter version up-to-date ensures we benefit from the latest improvements and bug fixes. The new linters help maintain code quality by catching potential issues early.