Skip to content
This repository was archived by the owner on May 6, 2022. It is now read-only.

Add support for generic API extensions#115

Merged
pmorie merged 1 commit into
masterfrom
generic-actions
Mar 23, 2018
Merged

Add support for generic API extensions#115
pmorie merged 1 commit into
masterfrom
generic-actions

Conversation

@pmorie

@pmorie pmorie commented Mar 9, 2018

Copy link
Copy Markdown
Contributor

WIP, so far has raised a couple questions for cloudfoundry/servicebroker#431

@coveralls

coveralls commented Mar 9, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 91.996% when pulling 148f0f2 on generic-actions into c231fb9 on master.

@pmorie
pmorie force-pushed the generic-actions branch 3 times, most recently from 95d8b11 to f5b3bec Compare March 21, 2018 14:23
@pmorie pmorie changed the title WIP: add support for generic API extensions Add support for generic API extensions Mar 21, 2018
@pmorie
pmorie requested a review from kibbles-n-bytes March 21, 2018 15:16
@n3wscott

Copy link
Copy Markdown
Contributor

Awesome. 👍

Comment thread v2/types.go Outdated
// endpoint(s) can be local to the Service Broker or on a remote server. If
// local to the Service Broker the same authentication method for normal
// Serivce Broker calls MUST be used.
DiscoveryURL string `json:"discovery_url,omitmpty"`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo with omitempty

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@kibbles-n-bytes kibbles-n-bytes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pmorie
pmorie merged commit c57d7cd into master Mar 23, 2018
@mszostok
mszostok deleted the generic-actions branch May 28, 2020 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants