Skip to content

Show info icons and tooltips consistently for cluster options - #8227

Open
KhizerRehan wants to merge 1 commit into
kubermatic:mainfrom
KhizerRehan:8190-info-icons
Open

Show info icons and tooltips consistently for cluster options#8227
KhizerRehan wants to merge 1 commit into
kubermatic:mainfrom
KhizerRehan:8190-info-icons

Conversation

@KhizerRehan

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds the missing info icons on the Audit Logging, User Cluster Logging and User Cluster Monitoring options and makes their tooltips readable when the option is disabled, so every cluster setting explains itself consistently.

Before:

  • Missing info icons
  • Missing tooltips
Screenshot 2026-07-31 at 3 29 13 PM

After:

Screenshot 2026-07-31 at 3 28 14 PM

(On Disabled Info Icon)
Screenshot 2026-07-31 at 3 28 19 PM

  • Add ℹ️ icons
  • Show tooltips in disabled
  • Show tooltips on default/enforce in both cases (That is why "@if" syntax as been removed and instead ternary operator is used) to show tool for default scenario and enforced scenario

Which issue(s) this PR fixes:

NONE

What type of PR is this?
/kind bug
/kind design

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Show info icons with tooltips for all cluster options, including disabled ones

Documentation:

NONE

Test issue:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). test-issue/none Denotes a PR that doesn't need a test issue (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/design Categorizes issue or PR as related to design. labels Jul 31, 2026
@kubermatic-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ahmadhamzh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2026

@ahmadhamzh ahmadhamzh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the tooltip is needed for the all default/enabled state messages like "Enable log collection for this user cluster" mostly just restate the checkbox label.
I'd suggest only showing an info icon when there's actually something non-obvious to explain (e.g. the enforced-by-admin state), rather than adding one to every checkbox by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. kind/design Categorizes issue or PR as related to design. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. test-issue/none Denotes a PR that doesn't need a test issue (changes).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants