Show info icons and tooltips consistently for cluster options - #8227
Show info icons and tooltips consistently for cluster options#8227KhizerRehan wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Not sure the tooltip is needed for the all default/enabled state messages like "Enable log collection for this user cluster" mostly just restate the checkbox label.
I'd suggest only showing an info icon when there's actually something non-obvious to explain (e.g. the enforced-by-admin state), rather than adding one to every checkbox by default.
What this PR does / why we need it:
This PR adds the missing info icons on the Audit Logging, User Cluster Logging and User Cluster Monitoring options and makes their tooltips readable when the option is disabled, so every cluster setting explains itself consistently.
Before:
After:
(On Disabled Info Icon)

Which issue(s) this PR fixes:
NONE
What type of PR is this?
/kind bug
/kind design
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
Test issue: