Skip to content

Fix black focus outlines in dark theme after Angular v21 upgrade - #8226

Merged
kubermatic-bot merged 1 commit into
kubermatic:mainfrom
KhizerRehan:8190-black-focus-ring
Aug 4, 2026
Merged

Fix black focus outlines in dark theme after Angular v21 upgrade#8226
kubermatic-bot merged 1 commit into
kubermatic:mainfrom
KhizerRehan:8190-black-focus-ring

Conversation

@KhizerRehan

@KhizerRehan KhizerRehan commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR fixes the black outlines that appear around radio buttons and dropdown options in dark theme, regressed by

Ref: #8084
Fixes: #8190

Before
Screenshot 2026-07-31 at 12 54 37 AM

Screenshot 2026-07-31 at 12 55 01 AM

After
Screenshot 2026-07-31 at 12 54 50 AM

Screenshot 2026-07-31 at 12 55 10 AM

Which issue(s) this PR fixes:

Ref: #8084

What type of PR is this?
/kind bug
/kind regression

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

Test issue:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). kind/regression Categorizes issue or PR as related to a regression from a prior release. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 31, 2026
@KhizerRehan
KhizerRehan marked this pull request as ready for review July 31, 2026 10:22
@kubermatic-bot kubermatic-bot added test-issue/none Denotes a PR that doesn't need a test issue (changes). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 31, 2026
@kubermatic-bot

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ahmadhamzh ahmadhamzh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2026
@kubermatic-bot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 0b1aac84eb45a0e572f2d98ae237152f0383b4b9

@kubermatic-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@kubermatic-bot
kubermatic-bot merged commit 8562812 into kubermatic:main Aug 4, 2026
10 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.31 milestone Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. test-issue/none Denotes a PR that doesn't need a test issue (changes).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI/UX enhancement

3 participants