Repository navigation
fix: score plugin now affects the path without global beam - #168
Merged
Merged
Conversation
computeScoresFull stored the beam scores before the plugin adjusted them, and makeBeams reads the stored scores, so plugin adjustments never changed the path when the global beam was off.
The protobuf check expanded the variables inside if(), so an unset Protobuf_VERSION left VERSION_LESS without its left operand and configuration failed (the Windows CI runner has no protobuf).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the global beam,
computeScoresFullstored the beam scores beforeapplyPluginToFullBeamchanged them.makeBeamsreads the stored scores, so the plugin (for example, partial-annotation input) never changed the result. The global-beam path, which is the default, applies the plugin in its own places and was not affected.The fix swaps the order. A new test in
analyzer_impl_test.ccchecks that a penalizing plugin changes the best path both with and without the global beam. Before the fix, the case without the global beam fails.🤖 Generated with Claude Code