fix(questions): verify provider answer question identities

[rudycelekli]

Problem and change

Closes #789.

Reproduction

The provider schema includes each answer's question and the instructions require answering supplied questions once in order. _validate ignores that question field and overwrites it with the positional input question. A reversed response therefore silently publishes the second answer under the first question.

The native generate_daily_questions caller with actual snapshots/stat registry and an injected structured provider response reproduces this silent reassociation (one failing assertion, 27 existing controls pass). Proposed scope: validate exact question identity before retaining answer prose; malformed, missing, duplicated, or reordered identities fail with the existing BriefingError contract. This is answer association, separate from prose quantity parsing in #784. No open production overlap or data edits.

Verification

The focused native module tests pass (28 passed). All six required commands passed at this exact SSH-signed head in a clean detached checkout with its own editable dev environment and initialized recursive submodule:

• ruff check . — passed
• ruff format --check . — passed
• benchmark-radar normalize-catalog — passed
• benchmark-radar classify — passed
• benchmark-radar build-data-release — passed
• pytest -q — passed

Full suite: 1641 passed in 85.91s (0:01:25). Regenerated catalog: 3,212 records/five sources, matching index/shard/archive identities. Python 3.12.11 and bundled Node runtime. Hosted checks are audited separately.

Prepared with AI assistance (gpt-6.1-sol), independently reviewed against native callers and regression evidence. Commit carries DCO signoff. No source-data, generated-data, or paper changes.

[rudycelekli]

330226 gpt-6.1-sol

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[ktwu01]

Closing as not planned. One author now has a cap of 10 open issues + PRs, and this account had 56 open PRs and 11 open issues, mostly paired with each other. We merged the three changes that fix silent data loss in the corpus (#723, #774, and #773 once rebased) and are closing the rest so review stays possible.

This is not a verdict that the change is wrong. If you think this one matters, reopen it later when you are under the cap, one at a time, with a reproduction from a real user or caller rather than a hypothetical edge case.

不是否定这个改动本身。为保证评审能跟上，同一作者最多同时保留 10 个未关闭的 issue/PR；该账号曾有 56 个未关闭 PR 和 11 个 issue。已合并修复语料静默丢失的三个改动，其余先关闭。若认为本条重要，请在低于上限后逐个重新打开，并附真实用户或调用方的复现。

---

Generated by Claude Code