Repository navigation
fix(site): preserve CSS strings when removing comments - #799
Closed
rudycelekli wants to merge 1 commit into
Closed
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
Contributor
Author
|
330226 gpt-6.1-sol |
Owner
|
Closing as not planned. One author now has a cap of 10 open issues + PRs, and this account had 56 open PRs and 11 open issues, mostly paired with each other. We merged the three changes that fix silent data loss in the corpus (#723, #774, and #773 once rebased) and are closing the rest so review stays possible. This is not a verdict that the change is wrong. If you think this one matters, reopen it later when you are under the cap, one at a time, with a reproduction from a real user or caller rather than a hypothetical edge case. 不是否定这个改动本身。为保证评审能跟上,同一作者最多同时保留 10 个未关闭的 issue/PR;该账号曾有 56 个未关闭 PR 和 11 个 issue。已合并修复语料静默丢失的三个改动,其余先关闭。若认为本条重要,请在低于上限后逐个重新打开,并附真实用户或调用方的复现。 Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Closes #788.
Reproduction
The Pages stylesheet minifier protects only unescaped double-quoted substrings before deleting comments. Valid single-quoted
url('a/*b*/c.png')becomesurl('ac.png'). An escaped quote can likewise expose literal comment markers. Quotes inside actual comments can cause a protected substring to span the comment terminator and preserve/delete the wrong text.The actual script main caller on a temporary valid stylesheet reproduces two regression failures with four existing controls passing. Proposed scope: tokenize comments and both escaped quote forms together, removing only actual comments before whitespace trimming. No new browser dependency or site redesign; no production-file overlap in open PR inventory.
Verification
The focused native module tests pass (6 passed). All six required commands passed at this exact SSH-signed head in a clean detached checkout with its own editable dev environment and initialized recursive submodule:
ruff check .— passedruff format --check .— passedbenchmark-radar normalize-catalog— passedbenchmark-radar classify— passedbenchmark-radar build-data-release— passedpytest -q— passedFull suite: 1642 passed in 95.79s (0:01:35). Regenerated catalog: 3,212 records/five sources, matching index/shard/archive identities. Python 3.12.11 and bundled Node runtime. Hosted checks are audited separately.
Prepared with AI assistance (gpt-6.1-sol), independently reviewed against native callers and regression evidence. Commit carries DCO signoff. No source-data, generated-data, or paper changes.