Skip to content

fix(corpus): preserve case-sensitive exact identifiers - #793

Closed
rudycelekli wants to merge 1 commit into
ktwu01:mainfrom
rudycelekli:fix/radar-case-sensitive-identity-20261006
Closed

rudycelekli wants to merge 1 commit into
ktwu01:mainfrom
rudycelekli:fix/radar-case-sensitive-identity-20261006

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Problem and change

Closes #783.

Reproduction

The cumulative corpus lowercases entire generic URLs and OpenReview identifiers. Distinct case-sensitive path/query values or opaque forum IDs therefore share an exact artifact identity and their observations merge.

Using the native build_corpus caller with two valid records (https://example.com/Benchmark?version=A and https://example.com/benchmark?version=a) produces one artifact with two observations. Two OpenReview forum IDs differing only in letter case also collapse. A hostname-only case change should still merge.

Regression assertions in the existing corpus module reproduce three failures with nine passing controls on current main bcd699f. Proposed scope: retain case in opaque OpenReview IDs and generic URL paths/queries, while retaining known case-insensitive host/GitHub/DOI/arXiv normalization. No source or generated data edits.

The freshly reviewed open PR file inventory has no corpus.py change; existing exact-link deduplication work is retained.

Verification

The focused native module tests pass (12 passed). All six required commands passed at this exact SSH-signed head in a clean detached checkout with its own editable dev environment and initialized recursive submodule:

  • ruff check . — passed
  • ruff format --check . — passed
  • benchmark-radar normalize-catalog — passed
  • benchmark-radar classify — passed
  • benchmark-radar build-data-release — passed
  • pytest -q — passed

Full suite: 1644 passed in 90.97s (0:01:30). Regenerated catalog: 3,212 records/five sources, matching index/shard/archive identities. Python 3.12.11 and bundled Node runtime. Hosted checks are audited separately.

Prepared with AI assistance (gpt-6.1-sol), independently reviewed against native callers and regression evidence. Commit carries DCO signoff. No source-data, generated-data, or paper changes.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 14:10
@rudycelekli

Copy link
Copy Markdown
Contributor Author

330226 gpt-6.1-sol

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

ktwu01 commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Closing as not planned. One author now has a cap of 10 open issues + PRs, and this account had 56 open PRs and 11 open issues, mostly paired with each other. We merged the three changes that fix silent data loss in the corpus (#723, #774, and #773 once rebased) and are closing the rest so review stays possible.

This is not a verdict that the change is wrong. If you think this one matters, reopen it later when you are under the cap, one at a time, with a reproduction from a real user or caller rather than a hypothetical edge case.

不是否定这个改动本身。为保证评审能跟上,同一作者最多同时保留 10 个未关闭的 issue/PR;该账号曾有 56 个未关闭 PR 和 11 个 issue。已合并修复语料静默丢失的三个改动,其余先关闭。若认为本条重要,请在低于上限后逐个重新打开,并附真实用户或调用方的复现。


Generated by Claude Code

@ktwu01 ktwu01 closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corpus exact identities merge case-sensitive URL paths and forum IDs

3 participants