Skip to content

Count failed GitHub organization requests toward the quota - #717

Closed
rudycelekli wants to merge 2 commits into
ktwu01:mainfrom
rudycelekli:fix/github-org-budget
Closed

rudycelekli wants to merge 2 commits into
ktwu01:mainfrom
rudycelekli:fix/github-org-budget

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

GitHub organization outages used to bypass max_requests because the counter advanced only after a successful response. Count the request before dispatch so a configured one-request budget dispatches exactly one organization request through the HTTP helper even when it fails.

The regression reproduces three failed calls under max_requests=1 before the fix and one after. Focused suite: 88 passed; the original-source mutant fails the regression.

The HTTP helper retains its existing per-request retry policy.

Validation

All six repository-required checks passed in a fresh, detached checkout of 41bff3ff934f7f3831a492430e6393051fdf5cd9 with recursive submodules initialized at the repository-pinned paper commit:

  • ruff check .
  • ruff format --check .
  • benchmark-radar normalize-catalog
  • benchmark-radar classify
  • benchmark-radar build-data-release
  • pytest -q: 1466 passed, no skipped tests

The rebuild preserves all 3,212 catalog records, all five sources, and 67 snapshots. Only source code and regression tests are committed. The commit is signed and includes the DCO sign-off.

These are local verification results; GitHub checks may still be pending or absent.

Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
@rudycelekli

Copy link
Copy Markdown
Contributor Author

Agent-authored PR annotation: 330226 GPT.

@rudycelekli
rudycelekli requested a review from ktwu01 as a code owner September 30, 2026 19:39
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>

ktwu01 commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Closing as not planned. One author now has a cap of 10 open issues + PRs, and this account had 56 open PRs and 11 open issues, mostly paired with each other. We merged the three changes that fix silent data loss in the corpus (#723, #774, and #773 once rebased) and are closing the rest so review stays possible.

This is not a verdict that the change is wrong. If you think this one matters, reopen it later when you are under the cap, one at a time, with a reproduction from a real user or caller rather than a hypothetical edge case.

不是否定这个改动本身。为保证评审能跟上,同一作者最多同时保留 10 个未关闭的 issue/PR;该账号曾有 56 个未关闭 PR 和 11 个 issue。已合并修复语料静默丢失的三个改动,其余先关闭。若认为本条重要,请在低于上限后逐个重新打开,并附真实用户或调用方的复现。


Generated by Claude Code

@ktwu01 ktwu01 closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants