Repository navigation
Retry interrupted HTTP response reads - #716
Closed
rudycelekli wants to merge 1 commit into
Closed
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
Contributor
Author
|
Agent-authored PR annotation: 330226 GPT. |
Owner
|
Closing as not planned. One author now has a cap of 10 open issues + PRs, and this account had 56 open PRs and 11 open issues, mostly paired with each other. We merged the three changes that fix silent data loss in the corpus (#723, #774, and #773 once rebased) and are closing the rest so review stays possible. This is not a verdict that the change is wrong. If you think this one matters, reopen it later when you are under the cap, one at a time, with a reproduction from a real user or caller rather than a hypothetical edge case. 不是否定这个改动本身。为保证评审能跟上,同一作者最多同时保留 10 个未关闭的 issue/PR;该账号曾有 56 个未关闭 PR 和 11 个 issue。已合并修复语料静默丢失的三个改动,其余先关闭。若认为本条重要,请在低于上限后逐个重新打开,并附真实用户或调用方的复现。 Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped connection after response headers used to escape the HTTP retry loop as an IncompleteRead or ConnectionResetError. The HTTP helper now retries those failures within the existing attempt limit and keeps exhausted failures credential safe.
Four regressions cover recovery and exhaustion for both failures, including response closure and bounded backoff. The original-source mutant fails all four. Focused suite: 15 passed.
Validation
All six repository-required checks passed in a fresh, detached checkout of
65d5644ef33a4a4844eb825afc17cafd0fe01976with recursive submodules initialized at the repository-pinned paper commit:ruff check .ruff format --check .benchmark-radar normalize-catalogbenchmark-radar classifybenchmark-radar build-data-releasepytest -q: 1469 passed, no skipped testsThe rebuild preserves all 3,212 catalog records, all five sources, and 67 snapshots. Only source code and regression tests are committed. The commit is signed and includes the DCO sign-off.
These are local verification results; GitHub checks may still be pending or absent.