docs: modernize architecture, add REST API reference, and sync test suite counts - #1930
santusht06 wants to merge 2 commits into
Conversation
|
@santusht06 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the comprehensive documentation update. The architecture documentation and new documentation hub are a good improvement, and the overall scope is appropriate.
However, I’m requesting changes before approval because the API reference currently has several mismatches with the actual application routes:
/api/comparedocumentsrole1androle2query parameters, but the implementation currently expectsaandb./api/roadmapsis documented as returning{ "roadmaps": [...] }, while the route directly returns the roadmap data structure.- The documentation lists
/healthz, but the application currently exposes/health. - The API reference is described as complete, but existing endpoints such as the skill-progression and code-review APIs are not documented.
- Please also verify the
/api/progress/projectentry and ensure every documented endpoint actually exists with the documented request/response schema.
Please sync docs/api_reference.md against the current route implementations and update the examples/response schemas accordingly.
Once these API documentation discrepancies are corrected and the docs are verified against the current code, I’ll be happy to approve the PR.
|
Hi @komalharshita, thank you for the detailed review! I have addressed all the requested changes and synchronized
All tests continue to pass (663 passed, 4 skipped, 1 deselected). Ready for your re-review! |
Summary [required]
Elevates repository documentation to production grade by:
docs/architecture.mdto accurately reflect the modularsrc/layout, Blueprint routing, SQLAlchemy ORM persistence, CSRF/CSP security model, and interactive Mermaid sequence & data flow diagrams.docs/api_reference.mddocumenting all endpoints (/api/recommend,/api/search,/api/roadmaps,/api/compare,/api/portfolio-analysis,/api/github/export, and system health endpoints) with request/response schemas.docs/README.mddocumentation hub.README.mdandPULL_REQUEST_TEMPLATE.mdto reflect the currentpytesttesting suite with 660+ tests passing.Related Issue [required]
Closes #N/A (Documentation Upgrade)
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
docs/architecture.mddocs/api_reference.mddocs/README.mdREADME.mdPULL_REQUEST_TEMPLATE.mdpytest tests/.How to Test This PR [required]
docs/architecture.md,docs/api_reference.md, anddocs/README.md.README.mdandPULL_REQUEST_TEMPLATE.md.Self-Review Checklist [required]
docs/