Skip to content

fix(mcp): block build --push in read-only MCP mode#3828

Open
Ankitsinghsisodya wants to merge 2 commits into
knative:mainfrom
Ankitsinghsisodya:fix/mcp-readonly-build-push
Open

fix(mcp): block build --push in read-only MCP mode#3828
Ankitsinghsisodya wants to merge 2 commits into
knative:mainfrom
Ankitsinghsisodya:fix/mcp-readonly-build-push

fix(mcp): address review feedback - extract EnvMCPWrite constant

c129d48
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2026 in 1s

53.95% (+0.16%) compared to 0692d37

View this Pull Request on Codecov

53.95% (+0.16%) compared to 0692d37

Details

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 53.95%. Comparing base (0692d37) to head (c129d48).

Files with missing lines Patch % Lines
cmd/mcp.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3828      +/-   ##
==========================================
+ Coverage   53.79%   53.95%   +0.16%     
==========================================
  Files         200      200              
  Lines       23688    23688              
==========================================
+ Hits        12742    12781      +39     
+ Misses       9720     9673      -47     
- Partials     1226     1234       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.