Add ops connections and recommendation blocks for newer databases - #661
Merged
Conversation
- Add spec.connections (MatchRef -> kubedb.com/v1alpha2 database) to the 14 ops.kubedb.com ResourceDescriptors that were missing it. - Add the supervisor Recommendations block to the Operations page of the 11 kubedb.com/v1alpha2 ResourceOutlines that were missing it. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceDescriptors —
hub/resourcedescriptors/ops.kubedb.com/v1alpha1/Added
spec.connections(the sameMatchRefon{.spec.databaseRef.name}with theopslabel thatmysqlopsrequests.yamlalready had) to the 14 ops RDs that were missing it:aerospike, cassandra, clickhouse, db2, documentdb, etcd, hanadb, hazelcast, ignite, milvus, neo4j, oracle, qdrant, weaviate
Target
apiVersioniskubedb.com/v1alpha2for all 14 — those kinds exist only under v1alpha2 (unlike MySQL, which points atkubedb.com/v1). Kinds taken from the correspondinghub/resourcedescriptors/kubedb.com/v1alpha2/*.yamllabels (DB2,DocumentDB,HanaDB,ClickHouse,Neo4j,Etcd, …).ResourceOutlines —
hub/resourceoutlines/kubedb.com/v1alpha2/kubedb/Added the supervisor
Recommendationsblock to the Operations page (right afterRecent Operations, matchingv1/kubedb/mongodbs.yaml) of the 11 outlines that were missing it:cassandras, ignites, milvuses, neo4js, oracles, qdrants, rabbitmqs, singlestores, solrs, weaviates, zookeepers
The block is byte-identical to the existing copies in
clickhouses.yaml/druids.yaml.Deliberately not included
v1alpha2/kubedb/kafkas.yamlhas no Operations page at all, so there is nowhere to append the block — adding one would mean creating the whole page.v1/kubedb/kafkas.yamlalready has both blocks.db2s.yaml,documentdbs.yaml,hanadbs.yamloutlines were left alone — those DBs are not in the supervisor recommender set.Verification
cmd/resource-fmtproduces no further diff,cmd/check-edge-labelandcmd/check-embedexit 0,go build ./...is clean.make fmtcould not run locally (Docker daemon down), but the nativeresource-fmt/check-edge-labelpasses cover the two hub-specific passes it wraps.