Cleanup and restructuring in IWG (isotropic struc bulk and Dirichlet) - #16
Open
rinderer wants to merge 4 commits into
Open
Cleanup and restructuring in IWG (isotropic struc bulk and Dirichlet)#16rinderer wants to merge 4 commits into
rinderer wants to merge 4 commits into
Conversation
This is copied from the linear variant of isotropic struc dirichlet IWG.
With this we can utilize the nonlinear version of the isotropic struc bulk IWG for the linear and nonlinear variant.
For the bulk and dirichlet IWGs: The implementation for the linear and nonlinear variants are identical. For the bulk a minor modification was necessary, see previous commit: 78b351a Therefore, we can call the nonlinear variants and get rid of the linear ones.
They are not required, their functionality is implemented in the nonlinear variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linear and nonlinear implementations for the isotropic, struc bulk and the Dirichlet IWGs are very similar.
To reduce code duplication, minor changes are made to the nonlinear verisions.
The IWG factory now can call the nonlinear classes if a linear IWG is required, see: cd5d964
The linear classes are removed from the repository in: 8859d3f
All ctests finished successfully.