Repository navigation
Tell agents the rerun waits for Codex - #6
Merged
Merged
Conversation
An observed agent read "request a review — then re-run" as "wait for the review, then re-run" and hand-wrote a polling loop. Failures now print one chained command (review request, rerun, gh pr checks --watch) and state that the rerun itself waits up to review-timeout-seconds. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Summary
Testing
|
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b64bcb57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Also record in AGENTS.md that a literal Codex mention in a PR description becomes a Codex task and skips the automatic review. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request a fresh review — then re-runas "wait for the review to appear, then re-run". After posting the Codex review request comment it wrote its ownuntil gh api …/reviews …; sleep 15loop, and only reran the check after being challenged.gh run rerun RUN_ID --failed && gh pr checks PR --watch. The message also says the rerun itself waits up to the configuredreview-timeout-seconds.review-timeoutno longer says "Re-run after the review finishes"; it now tells the agent to rerun to keep waiting.failureOutput/summaryMarkdownnow take aMessageOptionsrecord (run id, review hint, LGTM mode, review timeout).docs/CONFIGURATION.mdreruns section are updated, anddist/is rebuilt.Test plan
npm run check(typecheck, tests, ncc build)10 min/90s)Generated with Devin