Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
solth
force-pushed
the
detail-view-loading-svg
branch
3 times, most recently
from
September 10, 2026 11:21
4b2d174 to
392b497
Compare
oliver-stoehr
suggested changes
Sep 16, 2026
oliver-stoehr
left a comment
oliver-stoehr
left a comment
Collaborator
There was a problem hiding this comment.
The loading icon does not hide when loading an audio file and keeps spinning in the background:
The loading icon should also be added to the externalView.xhtml.
And there is still an old loading icon present. I think it is broken quite some time now and not visible, anyway. It should be removed, now that we add a new loading icon:
<i class="fa fa-spinner fa-spin"/>inexternalView.xhtml<i class="fa fa-spinner fa-spin"/>inmediaDetail.xhtmlloadingIconinol_custom.js::showCanvasloadingIconinol_custom.js::hideCanvas#map > iinkitodo.css#loaderinmedia_detail_audio_waveform.js(Line 88 is probably the place where the new loading icon should be hidden, when loading an audio file.)
Co-authored-by: Oliver Stöhr <stoehr@effective-webwork.de>
solth
force-pushed
the
detail-view-loading-svg
branch
from
September 16, 2026 15:07
6c4f9cc to
3e0ef0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a small SVG loader graphic that is displayed when an image starts loading and removed/hidden when the rendering of the image/media finished, to proivide better feedback to the user. Thus fixes #7057
Bildschirmaufnahme.2026-09-01.um.14.14.04.mov
Note: I will provide backports of this fix for Kitodo
3.9.xand4.0.xonce this pull request has been approved