Skip to content

Add initial configuration for ESLint (fix Codacy issues) #7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stweil wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add initial configuration for ESLint (fix Codacy issues) #7096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c7b4c7
Add initial configuration for ESLint (fix Codacy issues)
stweil Jun 24, 2026
4250720
Update rules for ESLint
stweil Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"env": {
"browser": true,
"jquery": true,
"es6": true,
"es2021": true
},
"globals": {
"PF": "readonly",
"PrimeFaces": "readonly",
"jsf": "readonly",
"faces": "readonly",
"mojarra": "readonly"

@solth solth Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Mojarra as JSF implementation, but rather MyFaces, so why do we need to define "mojarra" as a global here? Does it occur somewhere in the code?

},
"rules": {
"no-undef": "error"

@solth solth Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to keep an eye on this, because there may be other false positives apart from "PF" etc. when marking supposedly undefined symbols.

}
}
Loading