Skip to content

[BUGFIX] Fix high-severity disallow lint violations - #2235

Merged
sebastian-meyer merged 2 commits into
kitodo:mainfrom
stweil:fix/codacy-high-disallow-violations
Oct 27, 2026
Merged

sebastian-meyer merged 2 commits into
kitodo:mainfrom
stweil:fix/codacy-high-disallow-violations

Conversation

@stweil

@stweil stweil commented Oct 26, 2026

Copy link
Copy Markdown
Member

Resolve the Codacy High "disallow" patterns: no-redeclare and no-use-before-define in the viewer/media-player JavaScript, no-global-assign on the PageView namespace globals, and no-invalid-double-slash-comments in the ShakaFrontend styles. All changes are behavior-preserving.

Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud)

Resolve the Codacy High "disallow" patterns: no-redeclare and
no-use-before-define in the viewer/media-player JavaScript,
no-global-assign on the PageView namespace globals, and
no-invalid-double-slash-comments in the ShakaFrontend styles. All
changes are behavior-preserving.

Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
stweil force-pushed the fix/codacy-high-disallow-violations branch from 96f5057 to 57a22ba Compare October 26, 2026 13:15
@sebastian-meyer sebastian-meyer added the ☇ bug A non-security related bug. label Oct 27, 2026
@sebastian-meyer
sebastian-meyer merged commit 5ba498b into kitodo:main Oct 27, 2026
10 checks passed
@stweil
stweil deleted the fix/codacy-high-disallow-violations branch October 27, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☇ bug A non-security related bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants