Repository navigation
[BUGFIX] Fix endless loader in validation form on failed requests - #2221
Merged
Merged
Conversation
Member
Author
|
Note that a test on a real installation is still pending. |
sebastian-meyer
requested changes
Oct 21, 2026
sebastian-meyer
previously approved these changes
Oct 21, 2026
Contributor
There was a problem hiding this comment.
Looks good to me! However, I can’t test it at the moment because my development environment is outdated and I don’t have the necessary project resources. I’ve assigned @beatrycze-volk as a reviewer since she restructured the validation form and the flow a bit and may be able to test the changes directly.
stweil
force-pushed
the
fix/validation-form-loader
branch
from
October 21, 2026 07:49
d8aaa94 to
5f5274e
Compare
beatrycze-volk
approved these changes
Oct 21, 2026
The Validation plugin removes its loading indicator only in the happy path of the fetch promise chain (and only after the response has been parsed as JSON). Any other outcome - a network error, an aborted connection, or a non-JSON error page - is never handled, so the spinner keeps spinning indefinitely, the submit button stays clickable, and each click starts another pending request. Handle all request outcomes and always restore the form: - catch network errors and non-JSON responses and show an error message instead - abort the request after a 60 second timeout and show a dedicated timeout message - disable the submit button while a request is pending so requests cannot stack This becomes visible when the server is slow or unavailable (the underlying validation middleware has a 30 second timeout of its own), leaving the user with a page that appears to be frozen until a reload. Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud) Signed-off-by: Stefan Weil <sw@weilnetz.de>
stweil
force-pushed
the
fix/validation-form-loader
branch
from
October 26, 2026 10:22
0b93ee9 to
4afa803
Compare
sebastian-meyer
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Validation plugin removes its loading indicator only in the happy path of the fetch promise chain (and only after the response has been parsed as JSON). Any other outcome - a network error, an aborted connection, or a non-JSON error page - is never handled, so the spinner keeps spinning indefinitely, the submit button stays clickable, and each click starts another pending request.
Handle all request outcomes and always restore the form:
This becomes visible when the server is slow or unavailable (the underlying validation middleware has a 30 second timeout of its own), leaving the user with a page that appears to be frozen until a reload.
Assisted-by: OpenCode / qwen3.8-27b-thinking (Alibaba Cloud)