Repository navigation
[BUGFIX] Make kitodo:databaseDocsGenerate work and improve its output - #2173
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
============================
============================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Is this still backwards-compatible with TYPO3 v12? Otherwise we should wait for Kitodo.Presentation v8. |
Member
Author
|
Type::lookupName() was added in DBAL 3.7.0. So: compatible with T12 as long as the installed DBAL is ≥ 3.7, but strictly speaking the code no longer works on the oldest DBAL (3.6.2–3.6.7) that T12 still allows. CI with T12 reports "Downgrading doctrine/dbal (4.4.3 => 3.10.6)" and therefore works fine. Maybe add a hint in the release notes for users with T12. |
- The command failed with "The requested database connection named 'Default' has not been configured" even though it never uses a database: injecting the DataMapper forced the DI container to build the PageRepository, whose constructor opens a connection. Read the extbase class configuration from the extension's Classes.php instead, and derive the column names from the property names (the domain models do not use explicit column names), removing the DataMapper and the unused ConfigurationManager dependency. - Fix a TypeError with DBAL 4, which TYPO3 v13 uses, because Type::getName() no longer exists; use Type::lookupName() instead. - The @var parser dropped everything after a generic part of the type, e.g. "@var int<1, max>|null The uid of the record" became "max>|null The uid of the record". Strip the whole type, including generics and unions, from the @var line. - Do not leave trailing whitespace on empty description lines. - Abort with a clear error message if the dlf TCA is not loaded, i.e. if the command is run from the extension source directory instead of a TYPO3 site, because the generated page would be missing all TCA labels and titles. - Regenerate the database documentation page, which also updates the command name in the tip and adds TCA labels that were added since it was last generated. Assisted-by: OpenCode / Qwen3.8-27b-thinking (Alibaba Cloud) Signed-off-by: Stefan Weil <sw@weilnetz.de>
stweil
force-pushed
the
fix-database-docs-command
branch
from
September 28, 2026 11:51
9dcf080 to
0e2d989
Compare
sebastian-meyer
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: OpenCode / Qwen3.8-27b-thinking (Alibaba Cloud)