Skip to content

Fix for issue 91 and issue 93 and issue 94 - #92

Merged
elsdvlee merged 12 commits into
mainfrom
issue91
Nov 21, 2025
Merged

Fix for issue 91 and issue 93 and issue 94#92
elsdvlee merged 12 commits into
mainfrom
issue91

Conversation

@elsdvlee

@elsdvlee elsdvlee commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What's changed

Change checklist

  • updated ontology, where necessary
  • updated shapes, where necessary
  • added or updated test cases, where necessary
  • any TODOs have been turned into trackable issues and referenced where necessary

Issue reference

Fixes #91 and #93 and #94

@elsdvlee
elsdvlee requested review from chrdebru and pmaria October 28, 2025 09:06
@elsdvlee

elsdvlee commented Oct 28, 2025

Copy link
Copy Markdown
Collaborator Author

Once approved, I will secure a new publication of the test cases.

chrdebru
chrdebru requested changes Oct 29, 2025
View reviewed changes

@chrdebru chrdebru left a comment •
edited by elsdvlee
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • metadata.csv is not updated
  • manifest.ttl is not updated
RMLLVTC0008d,Cycle: Self-Join,Test a cycle in nested fields: self-join,http://w3id.org/rml/lv/,mapping.ttl,application/json,,,,,,people.json,,,,,,true

@elsdvlee

elsdvlee commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator Author

@pmaria Can you exclude the test cases starting with 8 from the test case validation with SHACL shapes? They are supposed to fail during the SHACL validation.

@elsdvlee elsdvlee changed the title Fix for issue 91: Testing for cycles (test cases) Fix for issue 91 and issue 93 Oct 30, 2025
chrdebru
chrdebru reviewed Oct 31, 2025
View reviewed changes

@chrdebru chrdebru left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving final review over to @pmaria, but all looks good to me.

@elsdvlee elsdvlee mentioned this pull request Nov 13, 2025
Closed
@elsdvlee elsdvlee changed the title Fix for issue 91 and issue 93 Fix for issue 91 and issue 93 and issue 94 Nov 13, 2025
pmaria
pmaria reviewed Nov 18, 2025
View reviewed changes
Comment thread spec/section/joins.md Outdated
@elsdvlee
elsdvlee requested a review from chrdebru November 21, 2025 13:34
@elsdvlee
elsdvlee merged commit b3b5cd8 into main Nov 21, 2025
1 check passed
@elsdvlee
elsdvlee deleted the issue91 branch November 21, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmaria pmaria pmaria approved these changes
@chrdebru chrdebru Awaiting requested review from chrdebru

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Testing for cycles (test cases)

3 participants

@elsdvlee @chrdebru @pmaria