change(web): merge master into autocorrect for acceptance testing 🚂 - #16223
change(web): merge master into autocorrect for acceptance testing 🚂#16223jahorton wants to merge 6 commits into
Conversation
…ocorrect-acceptance-prep
User Test ResultsTest specification and instructions 🟥 SUITE_AUTOCORRECTABLE: Perform tests in scenarios where autocorrective behaviors should be enabled.
✅ SUITE_AUTOCORRECT_MULTITAPS: Perform tests in scenarios with niche cases related to autocorrect.6 tests in 2 groups PASSED
✅ SUITE_WITHOUT_AUTOCORRECT: Perform tests in scenarios where autocorrective behaviors should not be enabled.8 tests in 2 groups PASSED
Retesting Template |
Test Specs
SUITE_AUTOCORRECTABLE: Perform tests in scenarios where autocorrective behaviors should be enabled.GROUP_ANDROID_EUROLATIN: Perform all tests with the
|
|
I've created #16273 to address the current batch of failed user tests. |
…ocorrect-acceptance-prep
|
Noted, I'll try getting them done today. I have been doing section-testing almost half way done now. |
|
I got an error when installing Keyman Test for Android onto Android Emulator:
|
|
I'm not sure if TEST_SELECTED_KHMER_NEAR_MATCH should fail or not because it is recommending correctly from my user experience. |
…ocorrect-acceptance-prep
|
Test-bot: retest SUITE_AUTOCORRECTABLE GROUP_ANDROID_EUROLATIN TEST_SUGGESTIONS_ON_BKSP TEST_PERIOD_OVERWRITE_REVERSION TEST_PERIOD_APPLICATION_DELAYED_REVERSION TEST_DELAYED_ON_WORD TEST_DELAYED_ON_SPACE TEST_ROBUSTNESS With #16273's changes now merged into this PR, the previous test results for these should be addressed. |
Test ResultsSUITE_AUTOCORRECTABLE:GROUP_ANDROID_EUROLATIN:
GROUP_ANDROID_AMHARIC:
|
|
All test are passed. Can you run the build for iOS? |
|
@jahorton, I edited the comment above with the results for the remaining iOS tests. Only the |
|
OK, for the Eurolatin version of "robustness", fortunately, that one is probably addressed already - see #16290. I haven't yet merged its changes into this one, so you'd still see that issue here. I'll need to look into the Amharic one with more detail. |
…ocorrect-acceptance-prep
|
I've now made #16307 to address the GROUP_IOS TEST_ROBUSTNESS failures. |



This merges the latest
masterintoepic/autocorrectin order to begin acceptance testing for predictive-text.Build-bot: skip release:web release:android release:ios
User Testing
SUITE_AUTOCORRECTABLE: Perform tests in scenarios where autocorrective behaviors should be enabled.
GROUP_ANDROID_EUROLATIN: Perform all tests with the
sil_euro_latinkeyboard and an English-language lexical model active within this PR's artifact for Keyman for Android.GROUP_ANDROID_AMHARIC: Perform all tests with the
gff_amharickeyboard active along with its default associated lexical model within this PR's artifact for Keyman for Android.GROUP_IOS_EUROLATIN: Perform all tests with the
sil_euro_latinkeyboard and an English-language lexical model active within this PR's artifact for Keyman for iPhone and iOS.GROUP_IOS_AMHARIC: Perform all tests with the
gff_amharickeyboard active along with its default associated lexical model within this PR's artifact for Keyman for iPhone and iOS.TEST_CLEAR_CONTEXT: Verify that predictive text throws no errors when clearing the context / deleting all text.
TEST_PRED_CHAIN_APPLY: Apply numerous suggestions in sequence and verify that they apply properly.
TEST_SUGGESTIONS_ON_BKSP: Verify that reasonable suggestions are displayed for text after using BKSP to reach the end of a previous word.
TEST_UNSELECTED_KEEP: Verify that typing a complete, correctly-spelled word does not result in a selected suggestion matching the word.
sil_euro_latin: Typesearch.gff_amharic: Typeውስጥ. (Positionally, QWERTYxsk.)TEST_SELECTED_NEAR_MATCH: Using Keyman for Android, verify that typing a complete, correctly-spelled word does not result in a selected suggestion matching the word.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)TEST_PERIOD_APPLY_OVERWRITE: Check if punctuation typed immediately after applying a suggestion erases the whitespace.
sil_euro_latin: Typesearchi.gff_amharic: Typeጽሕ. (Positionally, QWERTY;y.)sil_euro_latin:.will do nicely.gff_amharic: the base-layer!key will work nicely.TEST_SPACE_APPLY_OVERWRITE: Check if whitespace typed immediately after applying a suggestion erases the whitespace.
sil_euro_latin: Typesearchi.gff_amharic: Typeጽሕ. (Positionally, QWERTY;y.)key.TEST_PUNCT_APPLICATION: Check if punctuation typed with a highlighted suggestion applies it and appears afterward.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)sil_euro_latin:.will do nicely.gff_amharic: the base-layer!key will work nicely.TEST_SPACE_APPLICATION: Check if punctuation typed with a highlighted suggestion applies it and appears afterward.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)key.and verify that it outputs a new.TEST_PERIOD_OVERWRITE_REVERSION: Check if punctuation typed immediately after applying a suggestion erases the whitespace.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)sil_euro_latin:.will do nicely.gff_amharic: the base-layer!key will work nicely.searchiorጽሕdepending on the test's keyboard.)TEST_PERIOD_APPLICATION_REVERSION: Check if punctuation typed immediately after applying a suggestion erases the whitespace.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)sil_euro_latin:.will do nicely.gff_amharic: the base-layer!key will work nicely.TEST_PERIOD_APPLICATION_DELAYED_REVERSION: Check if punctuation typed immediately after applying a suggestion erases the whitespace.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)sil_euro_latin:.will do nicely.gff_amharic: the base-layer!key will work nicely.TEST_DELAYED_ON_WORD: Check if deleting characters up to the end of an applied suggestion's main body displays a reversion.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)TEST_DELAYED_ON_SPACE: Check if deleting characters up to the end of an applied suggestion's main body displays a reversion.
sil_euro_latin: Typesearchi.gff_amharic: Typeውስጥል. (Positionally, QWERTYxskl.)TEST_DOUBLE_DELAYED: Check if two suggestions can be reverted in rapid succession.
TEST_REAPPLIED_SUGGESTIONS: Verify that re-applying a suggestion in the following manner does not cause error messages or notifications.
2. Type the following, depending on active keyboard:
-
sil_euro_latin: Typesearchi.-
gff_amharic: Typeውስጥ. (Positionally, QWERTYxsk.)2. Select any suggestion without surrounding quotes.
3. Tap the backspace key once, then apply the reversion.
4. Your originally chosen suggestion should be visible. Re-apply it.
5. No error should result, and the suggestion should apply properly.
TEST_ROBUSTNESS: Spend at least 5 minutes trying to "break" predictive text and/or cause it to work improperly. Report back on any issues discovered.
SUITE_AUTOCORRECT_MULTITAPS: Perform tests in scenarios with niche cases related to autocorrect.
GROUP_ANDROID_NICHE: Run the following tests on Keyman for Android.
GROUP_IOS_NICHE: Run the following tests on Keyman for iPhone and iPad.
TEST_MULTITAPS: Verify that the
.key onenglish_punct_rotarotates through the desired punctuation marks.Install the keyboard package found at https://jahorton.github.io/english_punct_rota.kmp.
It may be installed via the following QR link as well:
.key four times, rotating through.,,, and?, landing on!.Testing is important. (Include the space mark.)TEST_MULTITAP_OVERWRITE: Using a keyboard with a multitap punctuation rota key, check if punctuation typed immediately after applying a suggestion erases the whitespace, even on repeated taps.
Install the keyboard package found at https://jahorton.github.io/english_punct_rota.kmp.
It may be installed via the following QR link as well:
Type
testiManually apply the
testingsuggestion.Then tap the
.key four times, rotating through.,,, and?, landing on!.Verify that the results are
testing.,testing,,testing?, and the final result istesting!, with no appended whitespace.TEST_MULTITAP_APPLICATION: Using a keyboard with a multitap punctuation rota key, check if punctuation typed with a highlighted suggestion applies it and appears afterward, even on repeated taps.
Install the keyboard package found at https://jahorton.github.io/english_punct_rota.kmp.
It may be installed via the following QR link as well:
Type
testiand verify that it is selected / highlighted. (If it isn't, delete its text and retype - tap accuracy may help.)Then tap the
.key four times, rotating through.,,, and?, landing on!.Verify that the results are
testing.,testing,,testing?, and the final result istesting!, with no appended whitespace.SUITE_WITHOUT_AUTOCORRECT: Perform tests in scenarios where autocorrective behaviors should not be enabled.
GROUP_ANDROID_KHMER: Perform all tests with the
khmer_angkorkeyboard and an English-language lexical model active within this PR's artifact for Keyman for Android.GROUP_IOS_KHMER: Perform all tests with the
khmer_angkorkeyboard and an English-language lexical model active within this PR's artifact for Keyman for iPhone and iOS.TEST_UNSELECTED_KHMER_KEEP: Verify that typing a complete, correctly-spelled word does not result in a selected suggestion matching the word.
TEST_SELECTED_KHMER_NEAR_MATCH: Using Keyman for Android, verify that typing a complete, correctly-spelled word does not result in a selected suggestion matching the word.
TEST_SPACE_KHMER_APPLY_OVERWRITE: Check if punctuation typed immediately after applying a suggestion erases the whitespace.
key.TEST_KHMER_CANDIDATE: Verify that autocorrect does not currently function for Khmer due to limitations.
ចូឡាម.ចូឡាមណីappears as the lone predictive-text suggestion. (Requiressil.km.cndmodel be the active Khmer model; it's the current default, I believe.)🚧 Brainstorming possible extra angles to test... 🚧
Additional (?) types of tests to run:
can'=>can't- even ifcanis autoselected,can'tis valid.can't do-> backspace tocan', very can suggestioncan't.Also cross-reference and double-check handled cases in these have appropriate testing: