Adding FCC-SEED as option to all detectors and refactor IDEA/ALLEGRO vertex detector

[armin-ilg]

To ease the review process, please consider the following before opening a pull request:

• the code is sufficiently well documented (e.g. inline comments)
• the relevant README(s) were updated. See e.g. https://github.com/key4hep/k4geo/blob/main/detector/calorimeter/README.md or https://github.com/key4hep/k4geo/blob/main/FCCee/IDEA/compact/README.md
• the code is covered by tests. See https://github.com/key4hep/k4geo/blob/main/test/CMakeLists.txt
• the PR source branch has been rebased (--ff-only) to k4geo/main
• the PR does not contain any additions or modifications that do not belong to it
• The release notes below contain a succinct and comprehensive description of the changes that are sufficiently self-explanatory

If you are modifying detector dimensions or adding new xml parameters, also consider the following:

• the xml file free parameters that can not be modified without additional prescriptions are well indicated
• the changes in this PR have not introduced any overlaps. You can check so with the following command: ddsim --compactFile PATH_TO_COMPACT_FILE --runType run --ui.commandsInitialize "/geometry/test/run" > overlapDump.txt

BEGINRELEASENOTES

• Adding FCC-SEED vertex detector layout as option to ILD (see Adding truth info for FCC-ee ILD model, add vertex resolutions as inp… iLCSoft/ILDConfig#188), ALLEGRO, IDEA, and CLD (option CLD_o5_v01)
• Fixing CLD disk material budget from CLD_o2_v09 and CLD_o5_v01 on (Half the material budget in CLD vertex disks #613)
• Updating ALLEGRO vertex detector and silicon wrapper properties: 20x20 µm^2 pixels everywhere in vertex, 50x50 µm^2 pitch pixels in SiWr, only one layer of SiWr (see [ALLEGRO] - Silicon wrapper and vertex assumptions in FCC-config and k4geo #617)
• Refactoring IDEA/ALLEGRO vertex detector. Inner vertex, outer vertex, and disks are now in separate xml files and can be flexibly combined (see VertexComplete_o1_v04.xml). Ultra-light inner vertex is in a standalone xml file (VertexInnerBarrelUltraLight_o1_v04.xml)

ENDRELEASENOTES

[Zehvogel]

For CLD I think it would fit our versioning scheme better if you add the FCC-SEED as a new option, i.e. CLD_o5_v01 :)

[armin-ilg]

For CLD I think it would fit our versioning scheme better if you add the FCC-SEED as a new option, i.e. CLD_o5_v01 :)

The FCC-SEED option is now added as CLD_o5_v01, and the CLD disk material budget fix is CLD_o1_v09 (see #613)

[armin-ilg]

Hi. The PR is now ready for review.

@Victor-Schwan @tmadlener : Do you want FCC-SEED to be the default vertex detector in ILD?

@BrieucF @giovannimarchiori : This PR includes the changes for ALLEGRO (pixel pitches and only one layer of Silicon Wrapper). FCC-SEED can be used for the inner vertex if desired.

@lopezzot : For IDEA only the structure of the vertex detector xml file is changed. One can, however, also use FCC-SEED as inner vertex if desired.

@andresailer @Zehvogel : The FCC-SEED option is now added as CLD_o5_v01, and the CLD disk material budget fix is CLD_o1_v09 (see #613).

[Zehvogel]

Hi @armin-ilg thank you for the contribution!

This is a particularly CLD-centric problem, but I think the PR would benefit from a cleanup of the commit history.
In the case of changes to CLD, we would like a structure similar to

1. Copy version X as basis for version Y
2. Add feature Z to version Y
   Otherwise, it is very difficult to perform the review.

Let me know if you have questions on how to do this. :)

[tmadlener]

@Victor-Schwan @tmadlener : Do you want FCC-SEED to be the default vertex detector in ILD?

I think for now we prefer to stay with the current version to not introduce yet another moving part into our efforts of getting a full tracking/reconstruction chain going. We would then switch to this once we have a (technical) baseline in place.

Unrelated to ILD, this will almost certainly break the conversion to an Acts geometry that happens in the k4ActsTracking, so also the blueprint building in https://github.com/key4hep/k4ActsTracking/blob/main/k4ActsTracking/src/components/DD4hepBlueprintConstruction.cpp will have to be adapated accordingly.

[armin-ilg]

@Victor-Schwan @tmadlener : Do you want FCC-SEED to be the default vertex detector in ILD?

I think for now we prefer to stay with the current version to not introduce yet another moving part into our efforts of getting a full tracking/reconstruction chain going. We would then switch to this once we have a (technical) baseline in place.

Unrelated to ILD, this will almost certainly break the conversion to an Acts geometry that happens in the k4ActsTracking, so also the blueprint building in https://github.com/key4hep/k4ActsTracking/blob/main/k4ActsTracking/src/components/DD4hepBlueprintConstruction.cpp will have to be adapated accordingly.

Thanks for the feedback, I changed the default back to the CLD vertex (the one from CLD_o2_v09 with the fixed disk mat. budget).

Indeed k4ActsTracking doesn't work yet with all detectors using VertexBarrel_detailed/VertexEndcap_detailed. This is on my to do list and I would tackle it in a future PR (just need to add the two blueprints as you pointed out).