Create If Not Exists Transaction Operation Type - #3724
Conversation
There was a problem hiding this comment.
you added a new OperationState.SKIPPED however I think you've missed to update the constraint for tables transactional_model_operation_log, transactional_storage_path_consolidated_operation and transactional_storage_path_operation_log.
Also, since the introduction of flyway in 6.3.0 shouldn't these changes go in a new versioned migration instead of modifying v1? @006627
There was a problem hiding this comment.
@eduardojst10 Yes, since Flyway was introduced in 6.3.0, these changes should go into a new versioned migration rather than modifying V1.
There was a problem hiding this comment.
Latest commit moves and adds schema changes in the new V3 flyway schema migration
006627
left a comment
There was a problem hiding this comment.
A potential rollback issue has already been reported internally. Due to a race condition, a failed transaction could roll back an agent created by another transaction.
For now, the proposal is to never roll back OPTIMISTIC_CREATE_IF_NOT_EXISTS, treating it like READ in rollback().
The reason is that a PREMIS agent is not tied to a specific transaction, so rolling it back could remove an agent created or used by another transaction.
This is a trade-off, as agents created by a failed transaction would remain instead of being removed.
2874a30 to
9caf957
Compare
9caf957 to
bd1a0e5
Compare
As of the current commit, optimistic creates are no longer rolled back in storage, same as with delete operations. |
No description provided.