Repository navigation
Conversation
lukaskabc
marked this pull request as ready for review
November 11, 2026 16:33
ledsoft
reviewed
Nov 13, 2026
ledsoft
left a comment
Contributor
There was a problem hiding this comment.
Changing collection type from unordered to ordered retains skos:Collection as explicit type in the repository. Is this necessary? The ordered collection being instance of skos:Collection can be inferred from the class hierarchy.
Collaborator
Author
JOPA would not bind ordered collection to collection DTO (which is OWL Class |
…d introduce OrderedSkosCollectionDto
Collaborator
Author
|
Removed explicit skos:Collection type from ordered collection. If you want to clear local db: PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
DELETE {
?collection a skos:Collection
} WHERE {
?collection a skos:OrderedCollection
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #465
Implements: kbss-cvut/termit-ui#875
Frontend PR: kbss-cvut/termit-ui#924
This PR allows editing an existing SKOS Collection and changing its order type (converting ordered to unordered and vice versa).