Repository navigation
Conversation
…allow removing terms to which references exists. Add inverse reference checking for term pre-removal.
…nces managed during Term children recursive removal
…fault values and fix failing test
… and copy them back when constructing Term from TermInfo
…hen removing term with subterms
…drenToAllParents test
…o delegate vocabulary root terms handling to term repository service
…removal strategy to eliminate double children update causing test instability
…ject predicate and context
…ethod signatures by removing vocabulary parameter
…nerated vocabularies
… directly to RepositoryConnection
lukaskabc
force-pushed
the
lukaskabc/ui/744-support-term-force-removal
branch
from
September 15, 2026 08:29
6bae1c8 to
10e4e84
Compare
lukaskabc
force-pushed
the
lukaskabc/ui/744-support-term-force-removal
branch
from
September 15, 2026 08:30
10e4e84 to
939aa40
Compare
lukaskabc
marked this pull request as ready for review
September 15, 2026 09:42
ledsoft
requested changes
Sep 15, 2026
ledsoft
left a comment
Contributor
There was a problem hiding this comment.
Couple of minor code style comments. I also don't like the underscore in term_removal package name. I would prefer a single-word name (such as removal, the fact that the classes handle Term removal is clear from their name) or a nested package.
Contributor
|
When I remove a term and its child is supposed to become a root term, it does not become one. This causes it to disappear from the vocabulary, although it still exists in the repository. It is just missing the |
…en becomes root terms
Co-authored-by: Martin Ledvinka <martin.ledvinka@outlook.com>
ledsoft
requested changes
Sep 18, 2026
ledsoft
left a comment
Contributor
There was a problem hiding this comment.
Additional comments after re-review.
… query and hardcode skos:ConceptScheme to query string instead of parameter binding.
lukaskabc
force-pushed
the
lukaskabc/ui/744-support-term-force-removal
branch
from
September 21, 2026 05:30
c5715cb to
0d0340e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kbss-cvut/termit-ui#744
Frontend PR: kbss-cvut/termit-ui#864