Skip to content

[Enhancement] Support term force removal - #433

Merged
ledsoft merged 33 commits into
kbss-cvut:developmentfrom
lukaskabc:lukaskabc/ui/744-support-term-force-removal
Sep 21, 2026
Merged

ledsoft merged 33 commits into
kbss-cvut:developmentfrom
lukaskabc:lukaskabc/ui/744-support-term-force-removal

Conversation

@lukaskabc

@lukaskabc lukaskabc commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

kbss-cvut/termit-ui#744

Frontend PR: kbss-cvut/termit-ui#864

  • Added endpoint for listing references to specific Term
  • Updated endpoint for Term removal, allowing the specification of how the term should be removed

…allow removing terms to which references exists. Add inverse reference checking for term pre-removal.
…nces managed during Term children recursive removal
… and copy them back when constructing Term from TermInfo
…o delegate vocabulary root terms handling to term repository service
…removal strategy to eliminate double children update causing test instability
…ethod signatures by removing vocabulary parameter
@lukaskabc
lukaskabc force-pushed the lukaskabc/ui/744-support-term-force-removal branch from 6bae1c8 to 10e4e84 Compare September 15, 2026 08:29
@lukaskabc
lukaskabc force-pushed the lukaskabc/ui/744-support-term-force-removal branch from 10e4e84 to 939aa40 Compare September 15, 2026 08:30
@lukaskabc
lukaskabc marked this pull request as ready for review September 15, 2026 09:42
@lukaskabc
lukaskabc requested a review from ledsoft September 15, 2026 12:54
@lukaskabc lukaskabc changed the title [Enhancement] Add support for force term removal [Enhancement] Support term force removal Sep 15, 2026

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor code style comments. I also don't like the underscore in term_removal package name. I would prefer a single-word name (such as removal, the fact that the classes handle Term removal is clear from their name) or a nested package.

@ledsoft

ledsoft commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

When I remove a term and its child is supposed to become a root term, it does not become one. This causes it to disappear from the vocabulary, although it still exists in the repository. It is just missing the voc skos:hasTopConcept term statement

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments after re-review.

… query and hardcode skos:ConceptScheme to query string instead of parameter binding.
@lukaskabc
lukaskabc force-pushed the lukaskabc/ui/744-support-term-force-removal branch from c5715cb to 0d0340e Compare September 21, 2026 05:30
@lukaskabc
lukaskabc requested a review from ledsoft September 21, 2026 05:37

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledsoft
ledsoft merged commit 1b5b1c8 into kbss-cvut:development Sep 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants