Skip to content

Fix LinCowCell chain drop by stopping on shared links #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Firstyear merged 2 commits into from
Jan 29, 2026
Merged

Fix LinCowCell chain drop by stopping on shared links #147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f51b74
Fix LinCowCell chain drop by stopping on shared links
droideck Jan 22, 2026
e0c35dd
Apply the comment made by Firstyear
droideck Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/internals/lincowcell/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,18 +120,23 @@ impl<R> LinCowCellInner<R> {
impl<R> Drop for LinCowCellInner<R> {
fn drop(&mut self) {
// Ensure the default drop won't recursively drop the chain
let mut current = self.pin.lock().unwrap().take();
// If a link is not uniquely owned, stop to avoid breaking the chain
let mut pin_guard = self.pin.lock().unwrap();
let mut current = pin_guard.take();
drop(pin_guard);

// Drop the chain iteratively to avoid stack overflow
while let Some(arc) = current {
while let Some(mut arc) = current {
// Try to get exclusive ownership of the next link
match Arc::try_unwrap(arc) {
Ok(inner) => {
match Arc::get_mut(&mut arc) {
Comment thread
Firstyear marked this conversation as resolved.
Outdated
Some(inner) => {
// Continue with the next link.
current = inner.pin.lock().unwrap().take();
let mut next_guard = inner.pin.lock().unwrap();
current = next_guard.take();
drop(next_guard);
}
Err(_) => {
// Another reference exists, so we can safely let it drop normally without recursion
None => {
// Another reference exists; stop without breaking its chain
break;
}
}
Expand Down
19 changes: 12 additions & 7 deletions src/internals/lincowcell_async/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,18 +108,23 @@ impl<R> LinCowCellInner<R> {
impl<R> Drop for LinCowCellInner<R> {
fn drop(&mut self) {
// Ensure the default drop won't recursively drop the chain
let mut current = self.pin.lock().unwrap().take();
// If a link is not uniquely owned, stop to avoid breaking the chain
let mut pin_guard = self.pin.lock().unwrap();
let mut current = pin_guard.take();
drop(pin_guard);

// Drop the chain iteratively to avoid stack overflow
while let Some(arc) = current {
while let Some(mut arc) = current {
// Try to get exclusive ownership of the next link
match Arc::try_unwrap(arc) {
Ok(inner) => {
match Arc::get_mut(&mut arc) {
Some(inner) => {
// Continue with the next link.
current = inner.pin.lock().unwrap().take();
let mut next_guard = inner.pin.lock().unwrap();
current = next_guard.take();
drop(next_guard);
}
Err(_) => {
// Another reference exists, so we can safely let it drop normally without recursion
None => {
// Another reference exists; stop without breaking its chain
break;
}
}
Expand Down
Loading