-
-
Notifications
You must be signed in to change notification settings - Fork 346
Infra: Bump actions to migrate to node22 #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,13 +18,13 @@ jobs: | |||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||
| steps: | ||||||||||||||||||
| - name: Checkout | ||||||||||||||||||
| uses: actions/checkout@1e31de5234b9f8995739874a8ce0492dc87873e2 # https://github.com/actions/checkout/releases/tag/v4.0.0 | ||||||||||||||||||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # https://github.com/actions/checkout/releases/tag/v4.2.2 | ||||||||||||||||||
| with: | ||||||||||||||||||
| ref: ${{ github.event.pull_request.head.sha }} | ||||||||||||||||||
| token: ${{ github.token }} | ||||||||||||||||||
|
Comment on lines
+21
to
24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify reusable workflows consume declared sha input in checkout ref
rg -n -C3 'workflow_call:|inputs:|sha:' .github/workflows/docker_build.yml
rg -n -C2 'uses:\s*actions/checkout@|ref:\s*\${{\s*github\.event\.pull_request\.head\.sha\s*}}|ref:\s*\${{\s*inputs\.sha\s*}}' .github/workflows/docker_build.ymlRepository: kafbat/kafka-ui Length of output: 453 🏁 Script executed: cat -n .github/workflows/docker_build.yml | head -30Repository: kafbat/kafka-ui Length of output: 1059 Checkout ignores reusable-workflow input SHA and uses invalid PR context. In Proposed fix - name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # https://github.com/actions/checkout/releases/tag/v4.2.2
with:
- ref: ${{ github.event.pull_request.head.sha }}
+ ref: ${{ inputs.sha }}
token: ${{ github.token }}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
|
|
||||||||||||||||||
| - name: Download artifacts | ||||||||||||||||||
| uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806 # https://github.com/actions/download-artifact/releases/tag/v4 | ||||||||||||||||||
| uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # https://github.com/actions/download-artifact/releases/tag/v4.1.8 | ||||||||||||||||||
| with: | ||||||||||||||||||
| name: kafbat-ui-${{ inputs.version }} | ||||||||||||||||||
| path: api/build/libs | ||||||||||||||||||
|
|
@@ -37,7 +37,7 @@ jobs: | |||||||||||||||||
| uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # https://github.com/docker/setup-buildx-action/releases/tag/v3.11.1 | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Cache Docker layers | ||||||||||||||||||
| uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # https://github.com/actions/cache/releases/tag/v4.3.0 | ||||||||||||||||||
| uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # https://github.com/actions/cache/releases/tag/v4.3.0 | ||||||||||||||||||
| with: | ||||||||||||||||||
| path: /tmp/.buildx-cache | ||||||||||||||||||
| key: ${{ runner.os }}-buildx-${{ inputs.sha }} | ||||||||||||||||||
|
|
@@ -81,7 +81,7 @@ jobs: | |||||||||||||||||
| docker image save kafka-ui:temp > /tmp/image.tar | ||||||||||||||||||
|
|
||||||||||||||||||
| - name: Upload docker image | ||||||||||||||||||
| uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # https://github.com/actions/upload-artifact/releases/tag/v4 | ||||||||||||||||||
| uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # https://github.com/actions/upload-artifact/releases/tag/v4.6.0 | ||||||||||||||||||
| with: | ||||||||||||||||||
| name: image | ||||||||||||||||||
| path: /tmp/image.tar | ||||||||||||||||||
|
|
||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.