Injecting DAO service through constructor to allow easier mocking#23
Merged
Conversation
…ing of the scrapper implementations.
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
===========================================
+ Coverage 2.2% 2.21% +0.01%
Complexity 7 7
===========================================
Files 19 20 +1
Lines 1771 1759 -12
Branches 389 389
===========================================
Hits 39 39
+ Misses 1723 1711 -12
Partials 9 9
Continue to review full report at Codecov.
|
Closed
|
A small suggestion here: #21 (comment) |
sudiptosarkar
requested changes
Oct 26, 2018
sudiptosarkar
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR for?
Fixes #22
This PR is to enable constructor injection of the DB related dependencies. This will allow us to easily mock the injected dependency and then test the scraper implementation.
What to emphasize on when reviewing?