docs(auth): point the cookie-flow hold at its tracking issue - #131
Merged
Conversation
The KDoc explains why sign-in is pinned to the deprecated cookie flow but left the reader to work out when that stops being true. #130 carries the three things that have to ship first and what the revert touches, including the `asSignupUrl` rewrite that sign-in testing would not catch. Named from both ends deliberately: the `grant_secret` alias is dormant until that day, so whoever finds it wondering why it exists lands on the same issue. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments-only follow-up to #128. Two lines of KDoc, no behaviour change.
This commit was written while #128 was in review and pushed to its branch a few minutes after it merged, so it was left stranded — cherry-picked onto
mainhere.What it does
Names #130 from both places that are holding:
PubkyClient.startAuthFlow— the KDoc explains why sign-in is pinned to the deprecated cookie flow but left the reader to work out when that stops being true. Restore grant auth once a Pubky Ring release ships on pubky 0.10 #130 carries the three things that have to ship first (rn-pubky publishes a pubky-0.10 build → Ring mergeschore/pubky-0.10.0→ Ring releases it) and what the revert touches, including theasSignupUrlrewrite that testing sign-in alone would not catch.SessionPayloadParser— thegrant_secretalias is dormant until that day, so whoever finds it wondering why it exists lands on the same issue.detektAllgreen.Worth knowing, since 0.1.2 has shipped
Verifying #128 on a Redmi Note 11 turned up a rollout gotcha that isn't a code problem: Android stores the launching URL as the base intent of Ring's task with
isPersistable=true, so a user who hit the broken build can be shown the oldsignin_granterror once after updating — Ring replays the stale intent rather than reading the new one.am force-stopand swiping the card out of recents both failed to clear it.Suggested release note for 0.1.2: if sign-in still fails after updating, close Pubky Ring from recents and try again. Full evidence in the #128 comment.
🤖 Generated with Claude Code