Use jupyter-ydoc's aset_progressively#607
Open
davidbrochart wants to merge 18 commits into
Open
Conversation
Contributor
|
|
Collaborator
Author
|
The test about conflict resolution fails because now the updates from the frontend are applied to an empty notebook (the cells are inserted after in the backend) so there is no conflict anymore, compared to before progressive document loading where the notebook is fully populated in the backend at synchronization time. |
Collaborator
Author
|
There are still 2 conflict tests that are failing. I don't understand because it should not be using the changes in this PR, and they pass on |
Collaborator
Author
|
CI is green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #593.