Skip to content

Don't set dirty=False on document load#603

Open
davidbrochart wants to merge 2 commits into
jupyterlab:mainfrom
davidbrochart:dirty
Open

Don't set dirty=False on document load#603
davidbrochart wants to merge 2 commits into
jupyterlab:mainfrom
davidbrochart:dirty

Conversation

@davidbrochart

Copy link
Copy Markdown
Collaborator

Fixes #601.

@github-actions

Copy link
Copy Markdown
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/dirty

@davidbrochart davidbrochart added the bug Something isn't working label Jun 22, 2026
@davidbrochart

Copy link
Copy Markdown
Collaborator Author

I understand that setting dirty=False on document load is not necessary anymore (after jupyter-ydoc v4), but I don't understand that keeping it makes loading from store fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Cannot reopen document after stopping server

1 participant