Skip to content

fix(hooks): replace PTY with subprocess.PIPE for reliable output capture #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raballew wants to merge 25 commits into
base: main
Choose a base branch
from
Open

fix(hooks): replace PTY with subprocess.PIPE for reliable output capture #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
cba1a35
fix(hooks): eliminate macOS PTY output race condition
raballew Jun 24, 2026
14099b8
ci: temporarily enable macOS tests on PRs to validate PTY fix
raballew Jun 24, 2026
7fefc93
test(hooks): cover reader_stop + BlockingIOError exit path
raballew Jun 24, 2026
98326f7
test(hooks): use real grandchild process to cover reader_stop path
raballew Jun 24, 2026
82d3b58
ci: retrigger #2
raballew Jun 24, 2026
40497e1
fix(test): don't set eof_seen on transient BlockingIOError in PtyTracker
raballew Jun 24, 2026
bffad38
ci: run macOS pytest 20x to validate PTY fix
raballew Jun 24, 2026
32c5aa8
fix(hooks): drain polls for full timeout instead of breaking on first…
raballew Jun 24, 2026
4b5896a
fix(hooks): extend reader grace period to DRAIN_TIMEOUT_SECONDS
raballew Jun 24, 2026
0f0d4f6
ci: bump e2e timeout from 30m to 35m
raballew Jun 25, 2026
131f51e
test(hooks): remove macos_pty_xfail markers
raballew Jun 25, 2026
58dfcf7
fix(hooks): replace PTY with subprocess.PIPE for output capture
raballew Jun 26, 2026
a6ae7f6
fix(hooks): use async non-blocking read on pipe fd for real-time output
raballew Jun 26, 2026
171f340
fix(hooks): yield to event loop after reader to flush LogStream
raballew Jun 26, 2026
4d7f11d
revert(ci): remove temporary validation CI changes
raballew Jun 30, 2026
fa80961
test(hooks): add edge case tests for pipe-based output capture
raballew Jun 30, 2026
83a62af
fix(hooks): address review findings for pipe-based output capture
raballew Jul 1, 2026
7eae6f7
fix(hooks): do not close pipe_fd eagerly after child exit
raballew Jul 1, 2026
e495ad0
ci: add temporary stress test for hooks (60 parallel runs)
raballew Jul 1, 2026
1be7dc4
ci: trigger stress test via push event
raballew Jul 1, 2026
611a5df
ci: remove temporary stress test workflow
raballew Jul 1, 2026
422e4a1
ci: stress test hooks 60x on ubuntu, macos-13, macos-14, macos-15
raballew Jul 1, 2026
dd97f3a
ci: remove temporary stress test workflow
raballew Jul 2, 2026
93af247
test(hooks): add coverage for defensive cleanup and error paths
raballew Jul 6, 2026
1e351bf
fix(test): make OSError read test deterministic across CI runners
raballew Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading