Skip to content

[dialogflow_task_executive] Fix merging #317 - #318

Merged
k-okada merged 1 commit into
jsk-ros-pkg:masterfrom
knorth55:fix-dialogflow
Dec 31, 2021
Merged

[dialogflow_task_executive] Fix merging #317#318
k-okada merged 1 commit into
jsk-ros-pkg:masterfrom
knorth55:fix-dialogflow

Conversation

@knorth55

Copy link
Copy Markdown
Member

Merging #317 is something wrong.
This PR fixes the incorrect merge.

See also #310

@knorth55 knorth55 added the bug label Dec 31, 2021
@knorth55 knorth55 mentioned this pull request Dec 31, 2021
9 tasks
@knorth55 knorth55 changed the title Fix merging #317 [dialogflow_task_executive] Fix merging #317 Dec 31, 2021
@knorth55

knorth55 commented Dec 31, 2021

Copy link
Copy Markdown
Member Author

This error can be found when you use this package with english.
sound play failed to speak because arg2 is incorrect.

https://github.com/ros-drivers/audio_common/blob/master/sound_play/scripts/soundplay_node.py#L260

@k-okada
k-okada merged commit 91888c5 into jsk-ros-pkg:master Dec 31, 2021
@k-okada

k-okada commented Dec 31, 2021

Copy link
Copy Markdown
Member

sorry for trouble.

@knorth55
knorth55 deleted the fix-dialogflow branch December 31, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants