Skip to content

Fix traffic count initialization, bug in date parsing by altair @mateusccoelho #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateusccoelho wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix traffic count initialization, bug in date parsing by altair @mateusccoelho #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c20697
Fix traffic count initialization, bug in date parsing by altair
mateusccoelho Aug 27, 2023
021c65f
Adding clarification about date formatting
mateusccoelho Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions streamlit_analytics/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ def show_results(counts, reset_callback, unsafe_password=None):
alt.themes.enable("streamlit")
except:
pass # probably old Streamlit version

df = pd.DataFrame(counts["per_day"])
# Formatting date by ISO-8601 to fix altair's date parsing bug
df["days"] = df["days"] + "T00:00:00"

base = alt.Chart(df).encode(
x=alt.X("monthdate(days):O", axis=alt.Axis(title="", grid=True))
)
Expand Down
4 changes: 2 additions & 2 deletions streamlit_analytics/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@

def reset_counts():
# Use yesterday as first entry to make chart look better.
yesterday = str(datetime.date.today() - datetime.timedelta(days=1))
today = datetime.date.today()
counts["total_pageviews"] = 0
counts["total_script_runs"] = 0
counts["total_time_seconds"] = 0
counts["per_day"] = {"days": [str(yesterday)], "pageviews": [0], "script_runs": [0]}
counts["per_day"] = {"days": [str(today)], "pageviews": [0], "script_runs": [0]}
counts["widgets"] = {}
counts["start_time"] = datetime.datetime.now().strftime("%d %b %Y, %H:%M:%S")

Expand Down