fix(ci): bump goreleaser to v2.17.0, verify archive integrity - #611
Merged
Conversation
goreleaser v2.12.7 silently produced corrupt .gz archives in the v1.12.0-rc1 release (#610): linux_amd64.gz and darwin_amd64.gz had valid gzip headers but corrupt deflate streams, with exit code 0 and no warnings. Reproduced locally 3/3 runs on v2.12.7; v2.17.0 (which built the clean v1.11.8) produced clean archives 3/3 with the same config. Also add a post-goreleaser verification step that gzip/unzip -t tests every dist archive — a silent corruption now fails the release job, which in the two-stage pipeline means the draft is never published. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the release pipeline to prevent publishing corrupted release artifacts by upgrading the pinned GoReleaser version and adding an explicit post-build integrity check for produced archives.
Changes:
- Bump GoReleaser pin in CI from
v2.12.7tov2.17.0to address corrupted.gzassets reported in #610. - Add a “Verify archive integrity” step that runs
gzip -t/unzip -toverdist/archives and fails the release job if any are corrupt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+97
to
+99
| # goreleaser can exit 0 while emitting corrupt archives (#610) — | ||
| # fail the job so a broken draft is never published (stage 2 only | ||
| # promotes what a human publishes, and a red job blocks that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the corrupt
.gzrelease assets reported in #610 (rc1'slinux_amd64.gz+darwin_amd64.gz).Root cause (A/B tested): goreleaser v2.12.7 (pinned in CI, Oct 2025) silently emits corrupt gz archives — reproduced 3/3 locally with our config (exit 0, no warnings). v2.17.0 (the version that built v1.11.8's clean assets via
goreleaser:latest) is clean 3/3 on the same config/machine.Changes:
Verify archive integritystep after goreleaser:gzip -t/unzip -tevery dist archive, failing the job on corruption — combined with the two-stage release, a broken draft can never be published/promotedAfter merge: tag
v1.12.0-rc2to supersede rc1.🤖 Generated with Claude Code